bryanck commented on PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#issuecomment-1885241611
Awesome! Thanks all for the feedback and guidance. I'll follow up with PRs
for the actual sink portion.
--
This is an automated message from the Apache Git Service.
To respond to the me
jbonofre commented on PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#issuecomment-1884919080
@Fokko awesome, thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
Fokko merged PR #8701:
URL: https://github.com/apache/iceberg/pull/8701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach
Fokko commented on PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#issuecomment-1884916386
Since there are no further comments, I'll go ahead and merge this. I would
like to express my gratitude to @bryanck for working on this since this will
help so many people in the Kafka comm
ajantha-bhat commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1413885283
##
core/src/main/java/org/apache/iceberg/avro/TypeToSchema.java:
##
@@ -238,8 +247,51 @@ public Schema primitive(Type.PrimitiveType primitive) {
throw new
bryanck commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1383589051
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/AvroUtil.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundat
nastra commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1382910267
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/AvroUtil.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundati
bryanck commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1382427212
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/CommitCompletePayload.java:
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache So
bryanck commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1382427250
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/DataWritten.java:
##
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software Fou
bryanck commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1379410092
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/DataWritten.java:
##
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software Fou
bryanck commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1379406817
##
core/src/main/java/org/apache/iceberg/avro/TypeToSchema.java:
##
@@ -238,8 +218,68 @@ public Schema primitive(Type.PrimitiveType primitive) {
throw new Unsu
rdblue commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1379221960
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/DataWritten.java:
##
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software Foun
rdblue commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1379219229
##
core/src/main/java/org/apache/iceberg/avro/TypeToSchema.java:
##
@@ -238,8 +218,68 @@ public Schema primitive(Type.PrimitiveType primitive) {
throw new Unsup
rdblue commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1375115365
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/CommitCompletePayload.java:
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Sof
danielcweeks commented on PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#issuecomment-1783596341
I'm a +1 on moving forward with this. I think there might still be an open
question about Iceberg/Avro Schema definitions, but I'm fine with either
resolution.
--
This is an auto
danielcweeks commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1375108603
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/CommitReadyPayload.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache
danielcweeks commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1375108167
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/TableName.java:
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software
danielcweeks commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1375106869
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/CommitCompletePayload.java:
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apac
bryanck commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1375106832
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/CommitCompletePayload.java:
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache So
danielcweeks commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1375105601
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/CommitCompletePayload.java:
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apac
bryanck commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1375104748
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/TableName.java:
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Found
danielcweeks commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1375100608
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/TableName.java:
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software
bryanck commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1375099924
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/CommitReadyPayload.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Softw
danielcweeks commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1375098695
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/CommitReadyPayload.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache
bryanck commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1375087754
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/TableName.java:
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Found
nastra commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1375084999
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/TableName.java:
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Founda
bryanck commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1375077725
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/TableName.java:
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Found
bryanck commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1375073000
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/CommitCompletePayload.java:
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache So
bryanck commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1375071931
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/CommitCompletePayload.java:
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache So
nastra commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1375054505
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/TableName.java:
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Founda
nastra commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1375054505
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/TableName.java:
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Founda
bryanck commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1375054000
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/Event.java:
##
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundatio
nastra commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1375053314
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/Event.java:
##
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundation
nastra commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1375050867
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/CommitCompletePayload.java:
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Sof
nastra commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1375049907
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/CommitCompletePayload.java:
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Sof
bryanck commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1367793649
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/Element.java:
##
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundati
bryanck commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1367793002
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/CommitCompletePayload.java:
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Sof
bryanck commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1367775412
##
kafka-connect/kafka-connect-events/src/test/java/org/apache/iceberg/connect/events/EventTestUtil.java:
##
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software F
bryanck commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1367772764
##
kafka-connect/kafka-connect-events/src/test/java/org/apache/iceberg/connect/events/EventTestUtil.java:
##
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software F
bryanck commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1367772385
##
kafka-connect/kafka-connect-events/src/test/java/org/apache/iceberg/connect/events/EventSerializationTest.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache S
bryanck commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1367772295
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/TableName.java:
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Found
bryanck commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1367771798
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/CommitCompletePayload.java:
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Sof
bryanck commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1367771040
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/Element.java:
##
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundati
ajantha-bhat commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1356710076
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/CommitCompletePayload.java:
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apach
ajantha-bhat commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1356434493
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/CommitCompletePayload.java:
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apach
ajantha-bhat commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1355382194
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/CommitCompletePayload.java:
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apach
ajantha-bhat commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1355276522
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/CommitCompletePayload.java:
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apach
bryanck commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1349335413
##
settings.gradle:
##
@@ -200,3 +202,6 @@ if (JavaVersion.current() == JavaVersion.VERSION_1_8) {
}
}
+include ":iceberg-kafka-connect:kafka-connect-events"
Rev
rdblue commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1349332017
##
settings.gradle:
##
@@ -200,3 +202,6 @@ if (JavaVersion.current() == JavaVersion.VERSION_1_8) {
}
}
+include ":iceberg-kafka-connect:kafka-connect-events"
Revi
rdblue commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1349331583
##
kafka-connect/kafka-connect-events/src/test/java/org/apache/iceberg/connect/events/EventTestUtil.java:
##
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software Fo
dungdm93 commented on PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#issuecomment-1750915594
I'm developing [`alluvial`](https://github.com/dungdm93/alluvial) project
which used to stream change logs from Kafka in `debezium` format to Iceberg
table.
Can't wait until this PR g
rdblue commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1348115184
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/Element.java:
##
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundatio
rdblue commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1348114157
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/CommitCompletePayload.java:
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Soft
bryanck commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1344653145
##
settings.gradle:
##
@@ -200,3 +202,6 @@ if (JavaVersion.current() == JavaVersion.VERSION_1_8) {
}
}
+include ":iceberg-kafka-connect:kafka-connect-events"
Rev
danielcweeks commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1344609437
##
settings.gradle:
##
@@ -200,3 +202,6 @@ if (JavaVersion.current() == JavaVersion.VERSION_1_8) {
}
}
+include ":iceberg-kafka-connect:kafka-connect-events"
danielcweeks commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1344514858
##
kafka-connect/kafka-connect-events/src/main/java/org/apache/iceberg/connect/events/Element.java:
##
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Fou
bryanck commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1344405778
##
core/src/main/java/org/apache/iceberg/data/avro/DecoderResolver.java:
##
@@ -51,6 +51,10 @@ public static T resolveAndRead(
return value;
}
+ public stat
ajantha-bhat commented on PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#issuecomment-1743437849
Very happy to see this contribution 👍
I have recently tested this project with Nessie catalog and liked it.
I just skimmed the files. Will definitely go through design docs
ajantha-bhat commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1342953382
##
kafka-connect/kafka-connect-events/src/test/java/org/apache/iceberg/connect/events/EventTestUtil.java:
##
@@ -1,22 +1,24 @@
/*
- * Licensed to the Apache Softw
bryanck commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1342952373
##
kafka-connect/kafka-connect-events/src/main/java/io/tabular/iceberg/connect/events/CommitCompletePayload.java:
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Sof
ajantha-bhat commented on code in PR #8701:
URL: https://github.com/apache/iceberg/pull/8701#discussion_r1342950793
##
kafka-connect/kafka-connect-events/src/main/java/io/tabular/iceberg/connect/events/CommitCompletePayload.java:
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apach
61 matches
Mail list logo
