Re: [PR] Kafka Connect: Commit coordination [iceberg]

eshishki commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1882755111 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Channel.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Commit coordination [iceberg]

danielcweeks merged PR #10351: URL: https://github.com/apache/iceberg/pull/10351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceb

Re: [PR] Kafka Connect: Commit coordination [iceberg]

danielcweeks commented on PR #10351: URL: https://github.com/apache/iceberg/pull/10351#issuecomment-2223231870 Thanks @bryanck and @fqaiser94. It's really great to get this one in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on PR #10351: URL: https://github.com/apache/iceberg/pull/10351#issuecomment-038127 I think I've addressed the latest feedback @fqaiser94 @danielcweeks LMK if there is anything else. -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1673403126 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1667378695 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/KafkaUtils.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1673365934 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/KafkaUtils.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1673353164 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1673336981 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CommitState.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1673335746 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Channel.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1673334947 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CommitState.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1673328544 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/CommitterFactory.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1673326336 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SinkWriter.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Commit coordination [iceberg]

danielcweeks commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1672743681 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/CommitterFactory.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1667378383 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Coordinator.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1667378383 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Coordinator.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1667378924 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Channel.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1667378695 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/KafkaUtils.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1667378606 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CommitState.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1667378383 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Coordinator.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1667378177 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Worker.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1667377890 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/KafkaClientFactory.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1667377846 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/KafkaClientFactory.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1667376742 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Coordinator.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Kafka Connect: Commit coordination [iceberg]

fqaiser94 commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1664602970 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Coordinator.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Kafka Connect: Commit coordination [iceberg]

fqaiser94 commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1663397086 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Worker.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Commit coordination [iceberg]

fqaiser94 commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1664211281 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] Kafka Connect: Commit coordination [iceberg]

fqaiser94 commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1663401716 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/KafkaUtils.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Kafka Connect: Commit coordination [iceberg]

fqaiser94 commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1663401716 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/KafkaUtils.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Kafka Connect: Commit coordination [iceberg]

fqaiser94 commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1663457632 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] Kafka Connect: Commit coordination [iceberg]

fqaiser94 commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1663456016 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] Kafka Connect: Commit coordination [iceberg]

fqaiser94 commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1663394084 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Worker.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on PR #10351: URL: https://github.com/apache/iceberg/pull/10351#issuecomment-2171758810 @ajantha-bhat @fqaiser94 Thanks for the reviews! I think I have addressed comments in case you want to take another look. @Fokko @nastra If either of you have time to take a look, that

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1641913835 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1641913080 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1641910518 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SinkWriter.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Commit coordination [iceberg]

ajantha-bhat commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1636542443 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SinkWriter.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Kafka Connect: Commit coordination [iceberg]

ajantha-bhat commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1636508431 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SinkWriter.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Kafka Connect: Commit coordination [iceberg]

ajantha-bhat commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1636493641 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Kafka Connect: Commit coordination [iceberg]

ajantha-bhat commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1636476953 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Coordinator.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] Kafka Connect: Commit coordination [iceberg]

ajantha-bhat commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1636475405 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/CatalogUtils.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632314152 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SinkWriter.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632313751 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SinkWriter.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632312924 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SinkWriter.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632312231 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632310383 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632309640 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632309203 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632308446 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632305518 ## kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/channel/CoordinatorTest.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632304257 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Coordinator.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632302742 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632302742 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632300134 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkConfig.java: ## @@ -80,7 +80,6 @@ public class IcebergSinkConfig extends AbstractCo

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632299892 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/CommitterFactory.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Kafka Connect: Commit coordination [iceberg]

bryanck commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1632299563 ## kafka-connect/kafka-connect-events/src/test/java/org/apache/iceberg/connect/events/EventTestUtil.java: ## @@ -45,7 +45,7 @@ private EventTestUtil() {} new S

Re: [PR] Kafka Connect: Commit coordination [iceberg]

fqaiser94 commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1621377408 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SinkWriter.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] Kafka Connect: Commit coordination [iceberg]

fqaiser94 commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1621333676 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] Kafka Connect: Commit coordination [iceberg]

fqaiser94 commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1616117443 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkTask.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] Kafka Connect: Commit coordination [iceberg]

ajantha-bhat commented on code in PR #10351: URL: https://github.com/apache/iceberg/pull/10351#discussion_r1607813508 ## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/CatalogUtils.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation