Re: [PR] Hive: Refactor HiveCatalog tests to use the core CatalogTests [iceberg]

2023-10-26 Thread via GitHub
nk1506 commented on code in PR #8918: URL: https://github.com/apache/iceberg/pull/8918#discussion_r1372806656 ## hive-metastore/src/test/java/org/apache/iceberg/hive/HiveMetastoreSetup.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Hive: Refactor HiveCatalog tests to use the core CatalogTests [iceberg]

2023-10-26 Thread via GitHub
nk1506 commented on code in PR #8918: URL: https://github.com/apache/iceberg/pull/8918#discussion_r1372801587 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -261,6 +261,12 @@ public void renameTable(TableIdentifier from, TableIdentifier original

Re: [PR] Hive: Refactor HiveCatalog tests to use the core CatalogTests [iceberg]

2023-10-25 Thread via GitHub
nastra commented on code in PR #8918: URL: https://github.com/apache/iceberg/pull/8918#discussion_r1371583467 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalogNew.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Hive: Refactor HiveCatalog tests to use the core CatalogTests [iceberg]

2023-10-25 Thread via GitHub
ajantha-bhat commented on code in PR #8918: URL: https://github.com/apache/iceberg/pull/8918#discussion_r1371580522 ## hive-metastore/src/test/java/org/apache/iceberg/hive/HiveMetastoreSetup.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Hive: Refactor HiveCatalog tests to use the core CatalogTests [iceberg]

2023-10-25 Thread via GitHub
nastra commented on code in PR #8918: URL: https://github.com/apache/iceberg/pull/8918#discussion_r1371579935 ## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalogNew.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Hive: Refactor HiveCatalog tests to use the core CatalogTests [iceberg]

2023-10-25 Thread via GitHub
ajantha-bhat commented on code in PR #8918: URL: https://github.com/apache/iceberg/pull/8918#discussion_r1371550325 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -261,6 +261,12 @@ public void renameTable(TableIdentifier from, TableIdentifier or

Re: [PR] Hive: Refactor HiveCatalog tests to use the core CatalogTests [iceberg]

2023-10-25 Thread via GitHub
nastra commented on code in PR #8918: URL: https://github.com/apache/iceberg/pull/8918#discussion_r1371576645 ## hive-metastore/src/test/java/org/apache/iceberg/hive/HiveMetastoreSetup.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +