Re: [PR] Flink: Fix TestIcebergSourceWithWatermarkExtractor flakiness [iceberg]

2023-12-18 Thread via GitHub
pvary commented on PR #9309: URL: https://github.com/apache/iceberg/pull/9309#issuecomment-1861394879 > @pvary you can monitor the actions/workflows for Flink CI. https://github.com/apache/iceberg/actions/workflows/flink-ci.yml Thanks @stevenzwu, I will try to follow what happens --

Re: [PR] Flink: Fix TestIcebergSourceWithWatermarkExtractor flakiness [iceberg]

2023-12-18 Thread via GitHub
stevenzwu commented on PR #9309: URL: https://github.com/apache/iceberg/pull/9309#issuecomment-1861098805 @pvary you can monitor the actions/workflows for Flink CI. https://github.com/apache/iceberg/actions/workflows/flink-ci.yml -- This is an automated message from the Apache Git Service

Re: [PR] Flink: Fix TestIcebergSourceWithWatermarkExtractor flakiness [iceberg]

2023-12-18 Thread via GitHub
pvary commented on PR #9309: URL: https://github.com/apache/iceberg/pull/9309#issuecomment-1859744822 @stevenzwu: The v1.16 does not have the `ALLOW_UNALIGNED_SOURCE_SPLITS` yet, so I had to remove this setting. I still hope that the fix would be enough itself. Merged the changes. Is the

Re: [PR] Flink: Fix TestIcebergSourceWithWatermarkExtractor flakiness [iceberg]

2023-12-18 Thread via GitHub
pvary merged PR #9309: URL: https://github.com/apache/iceberg/pull/9309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] Flink: Fix TestIcebergSourceWithWatermarkExtractor flakiness [iceberg]

2023-12-17 Thread via GitHub
stevenzwu commented on code in PR #9309: URL: https://github.com/apache/iceberg/pull/9309#discussion_r1429229476 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceWithWatermarkExtractor.java: ## @@ -95,8 +97,7 @@ public class TestIcebergSourceWi

Re: [PR] Flink: Fix TestIcebergSourceWithWatermarkExtractor flakiness [iceberg]

2023-12-17 Thread via GitHub
pvary commented on code in PR #9309: URL: https://github.com/apache/iceberg/pull/9309#discussion_r142906 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceWithWatermarkExtractor.java: ## @@ -304,6 +322,11 @@ public void testThrottling() thro

Re: [PR] Flink: Fix TestIcebergSourceWithWatermarkExtractor flakiness [iceberg]

2023-12-17 Thread via GitHub
pvary commented on code in PR #9309: URL: https://github.com/apache/iceberg/pull/9309#discussion_r1429221701 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceWithWatermarkExtractor.java: ## @@ -95,8 +97,7 @@ public class TestIcebergSourceWithWa

Re: [PR] Flink: Fix TestIcebergSourceWithWatermarkExtractor flakiness [iceberg]

2023-12-17 Thread via GitHub
stevenzwu commented on code in PR #9309: URL: https://github.com/apache/iceberg/pull/9309#discussion_r1429218088 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceWithWatermarkExtractor.java: ## @@ -95,8 +97,7 @@ public class TestIcebergSourceWi

Re: [PR] Flink: Fix TestIcebergSourceWithWatermarkExtractor flakiness [iceberg]

2023-12-16 Thread via GitHub
ajantha-bhat commented on PR #9309: URL: https://github.com/apache/iceberg/pull/9309#issuecomment-1858762537 Please also handle for other flink modules. Flakiness can come from any of the modules. -- This is an automated message from the Apache Git Service. To respond to the message, ple