mnzpk commented on code in PR #1747:
URL: https://github.com/apache/iceberg-python/pull/1747#discussion_r2052355193
##
pyiceberg/catalog/hive.py:
##
@@ -143,40 +144,47 @@ class _HiveClient:
"""Helper class to nicely open and close the transport."""
_transport: TTrans
kevinjqliu commented on PR #1747:
URL: https://github.com/apache/iceberg-python/pull/1747#issuecomment-2817319798
@abhisheksinha-pty im not really sure how those params are passed into
hive/kerberos. Here is where we [create the hive
client](https://github.com/kevinjqliu/iceberg-python/blob
abhisheksinha-pty commented on PR #1747:
URL: https://github.com/apache/iceberg-python/pull/1747#issuecomment-2817291285
I was getting this exact error. Thanks for fixing this issue, but any idea
how can I provide kerberos related details while creating catalog, like
kerberos principal , ke
Fokko merged PR #1747:
URL: https://github.com/apache/iceberg-python/pull/1747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceber
Fokko commented on code in PR #1747:
URL: https://github.com/apache/iceberg-python/pull/1747#discussion_r2044237743
##
pyiceberg/catalog/hive.py:
##
@@ -142,41 +143,42 @@
class _HiveClient:
"""Helper class to nicely open and close the transport."""
-_transport: TTran
Fokko commented on code in PR #1747:
URL: https://github.com/apache/iceberg-python/pull/1747#discussion_r2044239439
##
pyiceberg/catalog/hive.py:
##
@@ -142,41 +143,42 @@
class _HiveClient:
"""Helper class to nicely open and close the transport."""
-_transport: TTran
kevinjqliu commented on PR #1747:
URL: https://github.com/apache/iceberg-python/pull/1747#issuecomment-2800011503
cool CI passes now
@mnzpk please take a look when you have time :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
kevinjqliu commented on PR #1747:
URL: https://github.com/apache/iceberg-python/pull/1747#issuecomment-2799651827
CI's currently failing for main branch, see
https://github.com/apache/iceberg-python/pull/1899/files#r2040915222
--
This is an automated message from the Apache Git Service.
T
kevinjqliu commented on PR #1747:
URL: https://github.com/apache/iceberg-python/pull/1747#issuecomment-2798377068
Thanks for chiming in @hussein-awala @mnzpk
Please take a look at the new implementation.
The context manager (`__enter__` & `__exit__`) now manages the underlying
mnzpk commented on PR #1747:
URL: https://github.com/apache/iceberg-python/pull/1747#issuecomment-2797084917
> IMHO, it would be better to define the client as a
[cached_property](https://docs.python.org/3/library/functools.html#functools.cached_property),
and just return it. +1 for moving
Fokko commented on PR #1747:
URL: https://github.com/apache/iceberg-python/pull/1747#issuecomment-2776740059
Gentle ping @kevinjqliu. Any thoughts on the `cached_property` suggested by
@hussein-awala?
--
This is an automated message from the Apache Git Service.
To respond to the message,
Fokko commented on PR #1747:
URL: https://github.com/apache/iceberg-python/pull/1747#issuecomment-2755425442
@kevinjqliu I think this one is also good for 0.9.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
mnzpk commented on code in PR #1747:
URL: https://github.com/apache/iceberg-python/pull/1747#discussion_r1977349277
##
pyiceberg/catalog/hive.py:
##
@@ -167,15 +167,26 @@ def _init_thrift_client(self) -> None:
self._client = Client(protocol)
def __enter__(self) -
kevinjqliu commented on code in PR #1747:
URL: https://github.com/apache/iceberg-python/pull/1747#discussion_r1976692000
##
pyiceberg/catalog/hive.py:
##
Review Comment:
I wonder if we can just move `_init_thrift_client` out of the `__init__` and
into the context manager's
kevinjqliu commented on code in PR #1747:
URL: https://github.com/apache/iceberg-python/pull/1747#discussion_r1976690830
##
pyiceberg/catalog/hive.py:
##
@@ -167,6 +167,10 @@ def _init_thrift_client(self) -> None:
self._client = Client(protocol)
def __enter__(sel
mnzpk commented on code in PR #1747:
URL: https://github.com/apache/iceberg-python/pull/1747#discussion_r1976524834
##
pyiceberg/catalog/hive.py:
##
@@ -167,6 +167,10 @@ def _init_thrift_client(self) -> None:
self._client = Client(protocol)
def __enter__(self) ->
16 matches
Mail list logo
