Re: [PR] Fix downgrading of schema [iceberg-python]

2023-12-03 Thread via GitHub
Fokko merged PR #176: URL: https://github.com/apache/iceberg-python/pull/176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Fix downgrading of schema [iceberg-python]

2023-12-03 Thread via GitHub
Fokko commented on PR #176: URL: https://github.com/apache/iceberg-python/pull/176#issuecomment-1837794358 Thanks @danielcweeks and @HonahX for the review 🙌 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Fix downgrading of schema [iceberg-python]

2023-12-03 Thread via GitHub
Fokko commented on code in PR #176: URL: https://github.com/apache/iceberg-python/pull/176#discussion_r1413327467 ## pyiceberg/table/__init__.py: ## @@ -1412,13 +1412,22 @@ def commit(self) -> None: """Apply the pending changes and commit.""" new_schema = self.

Re: [PR] Fix downgrading of schema [iceberg-python]

2023-12-03 Thread via GitHub
HonahX commented on code in PR #176: URL: https://github.com/apache/iceberg-python/pull/176#discussion_r1413005467 ## pyiceberg/table/__init__.py: ## @@ -1412,13 +1412,22 @@ def commit(self) -> None: """Apply the pending changes and commit.""" new_schema = self

Re: [PR] Fix downgrading of schema [iceberg-python]

2023-12-02 Thread via GitHub
HonahX commented on code in PR #176: URL: https://github.com/apache/iceberg-python/pull/176#discussion_r1413005467 ## pyiceberg/table/__init__.py: ## @@ -1412,13 +1412,22 @@ def commit(self) -> None: """Apply the pending changes and commit.""" new_schema = self