Re: [PR] Fix dead links in docs [iceberg-python]

2024-03-03 Thread via GitHub
HonahX merged PR #493: URL: https://github.com/apache/iceberg-python/pull/493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Fix dead links in docs [iceberg-python]

2024-03-03 Thread via GitHub
HonahX commented on PR #493: URL: https://github.com/apache/iceberg-python/pull/493#issuecomment-1975404888 Thanks for fixing the CI config! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Fix dead links in docs [iceberg-python]

2024-03-03 Thread via GitHub
kevinjqliu commented on PR #493: URL: https://github.com/apache/iceberg-python/pull/493#issuecomment-1975396483 I just pushed the change following the same format as https://github.com/apache/iceberg-python/blob/main/.github/workflows/python-ci.yml#L25 this PR should now run the `chec

Re: [PR] Fix dead links in docs [iceberg-python]

2024-03-03 Thread via GitHub
kevinjqliu commented on PR #493: URL: https://github.com/apache/iceberg-python/pull/493#issuecomment-1975395425 Looks like its related to this https://stackoverflow.com/questions/61989951/github-action-workflow-not-running CI and integration test github actions both specifically r

Re: [PR] Fix dead links in docs [iceberg-python]

2024-03-03 Thread via GitHub
kevinjqliu commented on PR #493: URL: https://github.com/apache/iceberg-python/pull/493#issuecomment-1975394112 In fact, I'm not sure if the `Check Markdown links` github action has ever ran for this repo https://github.com/apache/iceberg-python/actions/workflows/check-md-link.yml -

Re: [PR] Fix dead links in docs [iceberg-python]

2024-03-03 Thread via GitHub
kevinjqliu commented on PR #493: URL: https://github.com/apache/iceberg-python/pull/493#issuecomment-1975393944 @HonahX that is weird. The github action is currently configured to run when there are changes to `mkdocs/**`, which should definitely include this PR. https://github.com/apach

Re: [PR] Fix dead links in docs [iceberg-python]

2024-03-03 Thread via GitHub
kevinjqliu commented on code in PR #493: URL: https://github.com/apache/iceberg-python/pull/493#discussion_r1510411481 ## mkdocs/docs/SUMMARY.md: ## @@ -26,6 +26,6 @@ - Releases - [Verify a release](verify-release.md) - [How to release](how-to-release.md) -- [Code Ref

Re: [PR] Fix dead links in docs [iceberg-python]

2024-03-03 Thread via GitHub
HonahX commented on code in PR #493: URL: https://github.com/apache/iceberg-python/pull/493#discussion_r1510408594 ## mkdocs/docs/SUMMARY.md: ## @@ -26,6 +26,6 @@ - Releases - [Verify a release](verify-release.md) - [How to release](how-to-release.md) -- [Code Referen