Re: [PR] Fix aggregate pushdown when optional DataFile stats are null [iceberg]

2024-05-23 Thread via GitHub
szehon-ho commented on PR #10273: URL: https://github.com/apache/iceberg/pull/10273#issuecomment-2127907725 Thanks @jkolash ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Fix aggregate pushdown when optional DataFile stats are null [iceberg]

2024-05-23 Thread via GitHub
szehon-ho merged PR #10273: URL: https://github.com/apache/iceberg/pull/10273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Fix aggregate pushdown when optional DataFile stats are null [iceberg]

2024-05-23 Thread via GitHub
szehon-ho commented on PR #10273: URL: https://github.com/apache/iceberg/pull/10273#issuecomment-2127814740 Thanks, will merge once tests pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fix aggregate pushdown when optional DataFile stats are null [iceberg]

2024-05-23 Thread via GitHub
jkolash commented on code in PR #10273: URL: https://github.com/apache/iceberg/pull/10273#discussion_r1612093999 ## api/src/test/java/org/apache/iceberg/expressions/TestAggregateEvaluator.java: ## @@ -95,6 +95,24 @@ public class TestAggregateEvaluator { FILE, MISSING_SOME_N

Re: [PR] Fix aggregate pushdown when optional DataFile stats are null [iceberg]

2024-05-22 Thread via GitHub
szehon-ho commented on code in PR #10273: URL: https://github.com/apache/iceberg/pull/10273#discussion_r1610731511 ## api/src/test/java/org/apache/iceberg/expressions/TestAggregateEvaluator.java: ## @@ -95,6 +95,24 @@ public class TestAggregateEvaluator { FILE, MISSING_SOME

Re: [PR] Fix aggregate pushdown when optional DataFile stats are null [iceberg]

2024-05-09 Thread via GitHub
szehon-ho commented on code in PR #10273: URL: https://github.com/apache/iceberg/pull/10273#discussion_r1596113287 ## api/src/main/java/org/apache/iceberg/expressions/CountNonNull.java: ## @@ -39,6 +39,9 @@ protected Long countFor(StructLike row) { @Override protected bo