Re: [PR] Fix CMake to support being a subproject [iceberg-cpp]

2025-01-14 Thread via GitHub
Xuanwo merged PR #29: URL: https://github.com/apache/iceberg-cpp/pull/29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Fix CMake to support being a subproject [iceberg-cpp]

2025-01-14 Thread via GitHub
wgtmac commented on PR #29: URL: https://github.com/apache/iceberg-cpp/pull/29#issuecomment-2590100956 Thanks for the confirmation! @zhjwpku @Fokko @Xuanwo Could you please merge this? It is a minor fix. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Fix CMake to support being a subproject [iceberg-cpp]

2025-01-14 Thread via GitHub
wgtmac commented on PR #29: URL: https://github.com/apache/iceberg-cpp/pull/29#issuecomment-2590048249 @zhjwpku Could you please try this? ``` cmake_minimum_required(VERSION 3.25) project(dummy VERSION 0.1.0 LANGUAGES CXX) include(FetchContent)