danielcweeks merged PR #11395:
URL: https://github.com/apache/iceberg/pull/11395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceb
RussellSpitzer commented on PR #11395:
URL: https://github.com/apache/iceberg/pull/11395#issuecomment-2444699712
@danielcweeks Could you check to see if the Javadoc change is what you were
looking for?
--
This is an automated message from the Apache Git Service.
To respond to the message,
bryanck commented on PR #11395:
URL: https://github.com/apache/iceberg/pull/11395#issuecomment-2442586580
I originally stripped off the query params to be on the safe side, but given
query params aren't specified in the URI format this change looks OK to me, +1
to Dan's comment about adding
danielcweeks commented on PR #11395:
URL: https://github.com/apache/iceberg/pull/11395#issuecomment-2438788687
Thanks @mrcnc , though overall it's really unfortunate that we have notably
different behavior between S3 and ADLS in the URI handling. S3 allows for
query params (though they're
RussellSpitzer commented on PR #11395:
URL: https://github.com/apache/iceberg/pull/11395#issuecomment-2438030667
LGTM. @danielcweeks This adds in that test I was looking for where URI would
fail, although looks like we have a bug in the current implementation anyway.
--
This is an autom
