sungwy merged PR #997:
URL: https://github.com/apache/iceberg-python/pull/997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
sungwy commented on PR #997:
URL: https://github.com/apache/iceberg-python/pull/997#issuecomment-2271552739
Hi @Fokko and @ndrluis thank you for your reviews, and @grobgl for reporting
this issue and getting the fix ready so quickly!
I've ran the CI, but it looks like it's failing the
ndrluis commented on PR #997:
URL: https://github.com/apache/iceberg-python/pull/997#issuecomment-2271435500
That's strange because I'm running your branch on my machine, so we
shouldn't be seeing different behavior.
--
This is an automated message from the Apache Git Service.
To respond
grobgl commented on PR #997:
URL: https://github.com/apache/iceberg-python/pull/997#issuecomment-2271295554
> Thank you, @grobgl. Could you please double-check your test
implementation? I removed the fix and the test didn't break.
Removing the fix does break the test for me. Possibly,
ndrluis commented on PR #997:
URL: https://github.com/apache/iceberg-python/pull/997#issuecomment-2271271527
Thank you, @grobgl. Could you please double-check your test implementation?
I removed the fix and the test didn't break.
--
This is an automated message from the Apache Git Service
ndrluis commented on PR #997:
URL: https://github.com/apache/iceberg-python/pull/997#issuecomment-2268945753
@grobgl Thank you for the fix. Could you add a integration test to guarantee
the expected behavior?
--
This is an automated message from the Apache Git Service.
To respond to the m
