Re: [PR] Feat: Add fail_if_exists param to create_table [iceberg-python]

2024-02-20 Thread via GitHub
hussein-awala commented on PR #415: URL: https://github.com/apache/iceberg-python/pull/415#issuecomment-1955078993 I will update the PR then 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Feat: Add fail_if_exists param to create_table [iceberg-python]

2024-02-16 Thread via GitHub
Fokko commented on PR #415: URL: https://github.com/apache/iceberg-python/pull/415#issuecomment-1948321931 @hussein-awala Thanks! You're right, and I think `create_table_if_not_exists` would be a cleaner solution, see #406. -- This is an automated message from the Apache Git Service. To

Re: [PR] Feat: Add fail_if_exists param to create_table [iceberg-python]

2024-02-13 Thread via GitHub
hussein-awala commented on PR #415: URL: https://github.com/apache/iceberg-python/pull/415#issuecomment-1942231488 Exactly, this implements `CREATE TABLE IF NOT EXISTS` and not `CREATE OR REPLACE`. If you prefer to have a new method `create_table_if_not_exists`, I can move the table

Re: [PR] Feat: Add fail_if_exists param to create_table [iceberg-python]

2024-02-13 Thread via GitHub
syun64 commented on PR #415: URL: https://github.com/apache/iceberg-python/pull/415#issuecomment-1941762880 > I think we should have some more discussion around this. I would prefer to have, analog to SQL, a `CREATE OR REPLACE` API. This feels analogous to the SQL `CREATE TABLE IF NOT

Re: [PR] Feat: Add fail_if_exists param to create_table [iceberg-python]

2024-02-13 Thread via GitHub
Fokko commented on PR #415: URL: https://github.com/apache/iceberg-python/pull/415#issuecomment-1940743319 I think we should have some more discussion around this. I would prefer to have, analog to SQL, a `CREATE OR REPLACE` API. -- This is an automated message from the Apache Git Servic