github-actions[bot] closed pull request #5544: Encryption integration and test
URL: https://github.com/apache/iceberg/pull/5544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
github-actions[bot] commented on PR #5544:
URL: https://github.com/apache/iceberg/pull/5544#issuecomment-2623222370
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If y
github-actions[bot] commented on PR #5544:
URL: https://github.com/apache/iceberg/pull/5544#issuecomment-2594191536
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
ggershinsky commented on PR #5544:
URL: https://github.com/apache/iceberg/pull/5544#issuecomment-2514437399
Thanks @nastra . This PR is heavily dependent on #7770 , so can be properly
rebased after the latter is merged. Both PRs are active, awaiting a progress in
the 7770.
--
This is an
nastra commented on PR #5544:
URL: https://github.com/apache/iceberg/pull/5544#issuecomment-2514279859
@ggershinsky is this PR still active? Could you please rebase and fix the
merge conflicts? I'll review this afterwards
--
This is an automated message from the Apache Git Service.
To res
hsiang-c commented on code in PR #5544:
URL: https://github.com/apache/iceberg/pull/5544#discussion_r1766090302
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -110,6 +115,15 @@ public void initialize(String inputName, Map properties) {
github-actions[bot] commented on PR #5544:
URL: https://github.com/apache/iceberg/pull/5544#issuecomment-2359659257
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
ggershinsky commented on code in PR #5544:
URL: https://github.com/apache/iceberg/pull/5544#discussion_r1718048825
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -512,6 +514,14 @@ public List snapshots() {
return snapshots;
}
+ public void setKekCa
ggershinsky commented on code in PR #5544:
URL: https://github.com/apache/iceberg/pull/5544#discussion_r1699502474
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##
@@ -106,18 +112,40 @@ public static String translateToIcebergProp(String
hmsPr
ggershinsky commented on code in PR #5544:
URL: https://github.com/apache/iceberg/pull/5544#discussion_r1699473244
##
api/src/main/java/org/apache/iceberg/encryption/EncryptingFileIO.java:
##
@@ -109,14 +111,19 @@ public InputFile newInputFile(ManifestFile manifest) {
}
ggershinsky commented on code in PR #5544:
URL: https://github.com/apache/iceberg/pull/5544#discussion_r1699473244
##
api/src/main/java/org/apache/iceberg/encryption/EncryptingFileIO.java:
##
@@ -109,14 +111,19 @@ public InputFile newInputFile(ManifestFile manifest) {
}
rdblue commented on code in PR #5544:
URL: https://github.com/apache/iceberg/pull/5544#discussion_r1676567998
##
core/src/main/java/org/apache/iceberg/TableMetadataParser.java:
##
@@ -274,10 +291,12 @@ public static TableMetadata read(FileIO io, String path) {
}
public s
rdblue commented on code in PR #5544:
URL: https://github.com/apache/iceberg/pull/5544#discussion_r1676515597
##
core/src/main/java/org/apache/iceberg/TableMetadataParser.java:
##
@@ -123,6 +127,7 @@ public static void internalWrite(
TableMetadata metadata, OutputFile out
rdblue commented on code in PR #5544:
URL: https://github.com/apache/iceberg/pull/5544#discussion_r1676514642
##
api/src/main/java/org/apache/iceberg/encryption/EncryptingFileIO.java:
##
@@ -109,14 +111,19 @@ public InputFile newInputFile(ManifestFile manifest) {
}
}
-
rdblue commented on code in PR #5544:
URL: https://github.com/apache/iceberg/pull/5544#discussion_r1676512526
##
.palantir/revapi.yml:
##
@@ -1018,6 +1018,17 @@ acceptedBreaks:
old: "method void
org.apache.iceberg.PositionDeletesTable.PositionDeletesBatchScan::(org.apach
rdblue commented on code in PR #5544:
URL: https://github.com/apache/iceberg/pull/5544#discussion_r1676510489
##
.palantir/revapi.yml:
##
@@ -1018,6 +1018,17 @@ acceptedBreaks:
old: "method void
org.apache.iceberg.PositionDeletesTable.PositionDeletesBatchScan::(org.apach
hsiang-c commented on code in PR #5544:
URL: https://github.com/apache/iceberg/pull/5544#discussion_r1650529269
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##
@@ -137,7 +163,47 @@ protected String tableName() {
@Override
public FileI
ggershinsky commented on code in PR #5544:
URL: https://github.com/apache/iceberg/pull/5544#discussion_r1642836390
##
core/src/main/java/org/apache/iceberg/TableMetadataParser.java:
##
@@ -472,10 +501,22 @@ public static TableMetadata fromJson(String
metadataLocation, JsonNode
RussellSpitzer commented on code in PR #5544:
URL: https://github.com/apache/iceberg/pull/5544#discussion_r1607047529
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##
@@ -137,17 +162,88 @@ protected String tableName() {
@Override
publi
ggershinsky commented on code in PR #5544:
URL: https://github.com/apache/iceberg/pull/5544#discussion_r1591261035
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestTableEncryption.java:
##
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
ggershinsky commented on code in PR #5544:
URL: https://github.com/apache/iceberg/pull/5544#discussion_r1590856537
##
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java:
##
@@ -146,21 +172,92 @@ protected void disableRefresh() {
}
protected String wr
ggershinsky commented on code in PR #5544:
URL: https://github.com/apache/iceberg/pull/5544#discussion_r1590852470
##
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java:
##
@@ -146,21 +172,92 @@ protected void disableRefresh() {
}
protected String wr
ggershinsky commented on code in PR #5544:
URL: https://github.com/apache/iceberg/pull/5544#discussion_r1590852470
##
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java:
##
@@ -146,21 +172,92 @@ protected void disableRefresh() {
}
protected String wr
ggershinsky commented on PR #5544:
URL: https://github.com/apache/iceberg/pull/5544#issuecomment-1768384984
The current PR sequence develops the encryption tools using Spark as a
usecase. But once the toolset converges, we'll certainly need the Flink support
and unitests.
--
This is an a
pvary commented on PR #5544:
URL: https://github.com/apache/iceberg/pull/5544#issuecomment-1768297698
@ggershinsky: Do we want to add Flink tests alongside the Spark tests as
well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
25 matches
Mail list logo
