Re: [PR] Docs: add metrics-reporting back [iceberg]

2024-05-29 Thread via GitHub
manuzhang commented on PR #10377: URL: https://github.com/apache/iceberg/pull/10377#issuecomment-2137743614 I created https://github.com/apache/iceberg/pull/10394 to deploy site on nightly docs changes. -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] Docs: add metrics-reporting back [iceberg]

2024-05-29 Thread via GitHub
manuzhang commented on PR #10377: URL: https://github.com/apache/iceberg/pull/10377#issuecomment-2137114187 @nastra Should this fix be deployed to nightly docs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Docs: add metrics-reporting back [iceberg]

2024-05-27 Thread via GitHub
manuzhang commented on code in PR #10377: URL: https://github.com/apache/iceberg/pull/10377#discussion_r1615665843 ## docs/mkdocs.yml: ## @@ -27,6 +27,7 @@ nav: - configuration.md - evolution.md - maintenance.md +- metrics-reporting.md Review Comment: I en

Re: [PR] Docs: add metrics-reporting back [iceberg]

2024-05-27 Thread via GitHub
nastra merged PR #10377: URL: https://github.com/apache/iceberg/pull/10377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Docs: add metrics-reporting back [iceberg]

2024-05-27 Thread via GitHub
nastra commented on code in PR #10377: URL: https://github.com/apache/iceberg/pull/10377#discussion_r1615616956 ## docs/mkdocs.yml: ## @@ -27,6 +27,7 @@ nav: - configuration.md - evolution.md - maintenance.md +- metrics-reporting.md Review Comment: Can you