Re: [PR] Docs: Sync specs to site via symlinks [iceberg]

2024-02-26 Thread via GitHub
nastra commented on PR #9779: URL: https://github.com/apache/iceberg/pull/9779#issuecomment-1963871923 @bitsondatadev I've verified the changes locally when reviewing and things look good and work as expected -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] Docs: Sync specs to site via symlinks [iceberg]

2024-02-24 Thread via GitHub
bitsondatadev commented on PR #9779: URL: https://github.com/apache/iceberg/pull/9779#issuecomment-1962358115 @manuzhang I'm on vacation, away from my computer and can't verify the link changes. I'll look at this when I return. -- This is an automated message from the Apache Git Service.

Re: [PR] Docs: Sync specs to site via symlinks [iceberg]

2024-02-23 Thread via GitHub
nastra merged PR #9779: URL: https://github.com/apache/iceberg/pull/9779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Docs: Sync specs to site via symlinks [iceberg]

2024-02-23 Thread via GitHub
manuzhang commented on PR #9779: URL: https://github.com/apache/iceberg/pull/9779#issuecomment-1961536940 @nastra Updated! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Docs: Sync specs to site via symlinks [iceberg]

2024-02-23 Thread via GitHub
nastra commented on PR #9779: URL: https://github.com/apache/iceberg/pull/9779#issuecomment-1961319538 I like that idea, but this doesn't render the Spec site correctly when running the site locally. This is because `{{% icebergVersion %}}` needs to be replaced with `{{ icebergVersion }}` s

Re: [PR] Docs: Sync specs to site via symlinks [iceberg]

2024-02-22 Thread via GitHub
manuzhang commented on PR #9779: URL: https://github.com/apache/iceberg/pull/9779#issuecomment-1960631535 @bitsondatadev @nastra please help review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to