Re: [PR] Correct schema behavior [iceberg-python]

2024-01-04 Thread via GitHub
Fokko merged PR #247: URL: https://github.com/apache/iceberg-python/pull/247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Correct schema behavior [iceberg-python]

2024-01-04 Thread via GitHub
Fokko commented on code in PR #247: URL: https://github.com/apache/iceberg-python/pull/247#discussion_r1442296384 ## pyiceberg/table/__init__.py: ## @@ -942,15 +942,16 @@ def snapshot(self) -> Optional[Snapshot]: return self.table.current_snapshot() def projectio

Re: [PR] Correct schema behavior [iceberg-python]

2024-01-03 Thread via GitHub
amogh-jahagirdar commented on code in PR #247: URL: https://github.com/apache/iceberg-python/pull/247#discussion_r1441260336 ## pyiceberg/table/__init__.py: ## @@ -942,15 +942,16 @@ def snapshot(self) -> Optional[Snapshot]: return self.table.current_snapshot() de

Re: [PR] Correct schema behavior [iceberg-python]

2024-01-03 Thread via GitHub
Fokko commented on code in PR #247: URL: https://github.com/apache/iceberg-python/pull/247#discussion_r1440202999 ## pyiceberg/table/__init__.py: ## @@ -942,15 +942,16 @@ def snapshot(self) -> Optional[Snapshot]: return self.table.current_snapshot() def projectio

Re: [PR] Correct schema behavior [iceberg-python]

2024-01-03 Thread via GitHub
Fokko commented on code in PR #247: URL: https://github.com/apache/iceberg-python/pull/247#discussion_r1440199047 ## pyiceberg/table/__init__.py: ## @@ -942,15 +942,16 @@ def snapshot(self) -> Optional[Snapshot]: return self.table.current_snapshot() def projectio

Re: [PR] Correct schema behavior [iceberg-python]

2024-01-01 Thread via GitHub
amogh-jahagirdar commented on code in PR #247: URL: https://github.com/apache/iceberg-python/pull/247#discussion_r1439114924 ## pyiceberg/table/__init__.py: ## @@ -942,15 +942,16 @@ def snapshot(self) -> Optional[Snapshot]: return self.table.current_snapshot() de