amogh-jahagirdar merged PR #9619:
URL: https://github.com/apache/iceberg/pull/9619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
amogh-jahagirdar commented on PR #9619:
URL: https://github.com/apache/iceberg/pull/9619#issuecomment-1930907632
I'll go ahead and merge, thanks @nastra for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
nastra commented on PR #9619:
URL: https://github.com/apache/iceberg/pull/9619#issuecomment-1929423667
@amogh-jahagirdar could you also take a look please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
abmo-x commented on code in PR #9619:
URL: https://github.com/apache/iceberg/pull/9619#discussion_r1478622304
##
core/src/test/java/org/apache/iceberg/util/TestLocationUtil.java:
##
@@ -46,6 +46,21 @@ public void testStripTrailingSlash() {
assertThat(LocationUtil.stripTrail
nastra commented on code in PR #9619:
URL: https://github.com/apache/iceberg/pull/9619#discussion_r141865
##
core/src/test/java/org/apache/iceberg/util/TestLocationUtil.java:
##
@@ -46,6 +46,21 @@ public void testStripTrailingSlash() {
assertThat(LocationUtil.stripTrail
nastra commented on code in PR #9619:
URL: https://github.com/apache/iceberg/pull/9619#discussion_r141865
##
core/src/test/java/org/apache/iceberg/util/TestLocationUtil.java:
##
@@ -46,6 +46,21 @@ public void testStripTrailingSlash() {
assertThat(LocationUtil.stripTrail
