Fokko merged PR #9147:
URL: https://github.com/apache/iceberg/pull/9147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach
Fokko commented on PR #9147:
URL: https://github.com/apache/iceberg/pull/9147#issuecomment-1868525212
Hey @irshadcc Sorry for the long wait here, and thanks for pinging me. Let's
get this in 🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
irshadcc commented on PR #9147:
URL: https://github.com/apache/iceberg/pull/9147#issuecomment-1868429638
kind ping @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
irshadcc commented on PR #9147:
URL: https://github.com/apache/iceberg/pull/9147#issuecomment-1848403130
@Fokko Can we merge this PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
irshadcc commented on PR #9147:
URL: https://github.com/apache/iceberg/pull/9147#issuecomment-1845560669
> Thanks for raising this @irshadcc, this looks good to me. I've left two
small comments, could you take a peek at those? Thanks for fixing this! 🙌
I've added the Javadoc and remov
Fokko commented on code in PR #9147:
URL: https://github.com/apache/iceberg/pull/9147#discussion_r1411617308
##
api/src/main/java/org/apache/iceberg/types/Types.java:
##
@@ -592,6 +594,13 @@ public Types.StructType asStructType() {
return this;
}
+public Schema
Fokko commented on code in PR #9147:
URL: https://github.com/apache/iceberg/pull/9147#discussion_r1411615389
##
api/src/main/java/org/apache/iceberg/expressions/NamedReference.java:
##
@@ -38,7 +38,8 @@ public String name() {
@Override
public BoundReference bind(Types.St
irshadcc commented on PR #9147:
URL: https://github.com/apache/iceberg/pull/9147#issuecomment-1833511276
@rdblue I would really appreciate if you could take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
irshadcc commented on PR #9147:
URL: https://github.com/apache/iceberg/pull/9147#issuecomment-1825679606
Resolves issue #9118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
