Fokko commented on code in PR #10397:
URL: https://github.com/apache/iceberg/pull/10397#discussion_r1620309427
##
core/src/main/java/org/apache/iceberg/rest/RESTMetricsReporter.java:
##
@@ -26,7 +26,11 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-class RESTMe
Fokko commented on PR #10397:
URL: https://github.com/apache/iceberg/pull/10397#issuecomment-2139053254
The URL in the `metrics-reporting.md` does look similar to the URLs that are
working, so probably it is failing because the class is not in the Javadoc.
Thanks again for reporting this @m
Fokko commented on PR #10397:
URL: https://github.com/apache/iceberg/pull/10397#issuecomment-2139034146
The correct url is:
https://iceberg.apache.org/javadoc/1.5.2/org/apache/iceberg/rest/RESTCatalog.html.
Looks like the paths are not correct
--
This is an automated message from the Apa
Fokko commented on PR #10397:
URL: https://github.com/apache/iceberg/pull/10397#issuecomment-2139028210
@manuzhang I think that would make more sense, but I would love to get
@nastra input here (he's currently on holiday).
--
This is an automated message from the Apache Git Service.
To re
Fokko commented on PR #10397:
URL: https://github.com/apache/iceberg/pull/10397#issuecomment-2139030717
The `RESTCatalog.html` is there on the `asf-site` branch:
https://github.com/apache/iceberg/blob/asf-site/javadoc/1.5.2/org/apache/iceberg/rest/RESTCatalog.html
--
This is an automated
manuzhang commented on PR #10397:
URL: https://github.com/apache/iceberg/pull/10397#issuecomment-2138839436
If we don't intend to make `RESTMetricsReporter` public, then we can just
remove the javadoc link on "Metrics Reporting" page.
--
This is an automated message from the Apache Git Se
manuzhang commented on PR #10397:
URL: https://github.com/apache/iceberg/pull/10397#issuecomment-2138796365
Default level of generating javadoc is public and protected.
`RESTMetricsReporter` is package private so its javadoc is not generated.
--
This is an automated message from the Apach
manuzhang commented on PR #10397:
URL: https://github.com/apache/iceberg/pull/10397#issuecomment-2138795012
RESTCatalog has javadoc at
https://github.com/apache/iceberg/blob/javadoc/1.5.2/org/apache/iceberg/rest/RESTCatalog.html.
It looks another issue when deploying to website.
--
This
Fokko commented on PR #10397:
URL: https://github.com/apache/iceberg/pull/10397#issuecomment-2138792529
Hmm, the file is missing here:
https://github.com/apache/iceberg/tree/javadoc/1.5.2/org/apache/iceberg/rest
--
This is an automated message from the Apache Git Service.
To respond to th
Fokko commented on PR #10397:
URL: https://github.com/apache/iceberg/pull/10397#issuecomment-2138788283
@manuzhang I see your comment in #10378. I don't think that the class being
private is the underlying issue of the missing javadoc. For example, the
RestCatalog doesn't have docs either:
Fokko commented on PR #10397:
URL: https://github.com/apache/iceberg/pull/10397#issuecomment-2138780007
@manuzhang How I read the doc is:
- You either enable the `RESTMetricsReporter` through the property, no need
to override the class.
- You implement a custom reporter by overridi
manuzhang commented on PR #10397:
URL: https://github.com/apache/iceberg/pull/10397#issuecomment-2138571831
cc @nastra @jbonofre
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
12 matches
Mail list logo
