Re: [PR] Core: Interface based DataFile reader and writer API [iceberg]

2025-05-21 Thread via GitHub
pvary commented on code in PR #12298: URL: https://github.com/apache/iceberg/pull/12298#discussion_r2100573472 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkObjectModels.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Core: Interface based DataFile reader and writer API [iceberg]

2025-05-21 Thread via GitHub
pvary commented on code in PR #12298: URL: https://github.com/apache/iceberg/pull/12298#discussion_r2100572403 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkObjectModels.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Core: Interface based DataFile reader and writer API [iceberg]

2025-05-20 Thread via GitHub
stevenzwu commented on code in PR #12298: URL: https://github.com/apache/iceberg/pull/12298#discussion_r2098584258 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkObjectModels.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Core: Interface based DataFile reader and writer API [iceberg]

2025-05-20 Thread via GitHub
stevenzwu commented on code in PR #12298: URL: https://github.com/apache/iceberg/pull/12298#discussion_r2098577496 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkObjectModels.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Core: Interface based DataFile reader and writer API [iceberg]

2025-04-11 Thread via GitHub
pvary commented on code in PR #12298: URL: https://github.com/apache/iceberg/pull/12298#discussion_r2039702540 ## core/src/main/java/org/apache/iceberg/io/ReadBuilder.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

Re: [PR] Core: Interface based DataFile reader and writer API [iceberg]

2025-04-11 Thread via GitHub
pvary commented on code in PR #12298: URL: https://github.com/apache/iceberg/pull/12298#discussion_r2039702540 ## core/src/main/java/org/apache/iceberg/io/ReadBuilder.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

Re: [PR] Core: Interface based DataFile reader and writer API [iceberg]

2025-04-11 Thread via GitHub
pvary commented on PR #12298: URL: https://github.com/apache/iceberg/pull/12298#issuecomment-2796962816 Extracted the proposed interfaces to a different PR, so it is easier to review them. See: #12774 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Core: Interface based DataFile reader and writer API [iceberg]

2025-04-11 Thread via GitHub
pvary commented on code in PR #12298: URL: https://github.com/apache/iceberg/pull/12298#discussion_r2039563923 ## core/src/main/java/org/apache/iceberg/io/ReadBuilder.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

Re: [PR] Core: Interface based DataFile reader and writer API [iceberg]

2025-04-11 Thread via GitHub
pvary commented on code in PR #12298: URL: https://github.com/apache/iceberg/pull/12298#discussion_r2039552868 ## core/src/main/java/org/apache/iceberg/io/ReadBuilder.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

Re: [PR] Core: Interface based DataFile reader and writer API [iceberg]

2025-04-11 Thread via GitHub
pvary commented on code in PR #12298: URL: https://github.com/apache/iceberg/pull/12298#discussion_r2039514284 ## core/src/main/java/org/apache/iceberg/io/AppenderBuilder.java: ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] Core: Interface based DataFile reader and writer API [iceberg]

2025-04-11 Thread via GitHub
pvary commented on code in PR #12298: URL: https://github.com/apache/iceberg/pull/12298#discussion_r2039506741 ## core/src/main/java/org/apache/iceberg/io/AppenderBuilder.java: ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] Core: Interface based DataFile reader and writer API [iceberg]

2025-04-11 Thread via GitHub
pvary commented on code in PR #12298: URL: https://github.com/apache/iceberg/pull/12298#discussion_r2039507754 ## core/src/main/java/org/apache/iceberg/io/AppenderBuilder.java: ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

Re: [PR] Core: Interface based DataFile reader and writer API [iceberg]

2025-04-10 Thread via GitHub
pvary commented on PR #12298: URL: https://github.com/apache/iceberg/pull/12298#issuecomment-2792008669 > > Are you suggesting that we should use Arrow as an intermediate format? > > That is one way, and personally, I'd be a fan, but I wasn't sure it was practical or not in the code b

Re: [PR] Core: Interface based DataFile reader and writer API [iceberg]

2025-04-10 Thread via GitHub
danielcweeks commented on code in PR #12298: URL: https://github.com/apache/iceberg/pull/12298#discussion_r2038212300 ## core/src/main/java/org/apache/iceberg/io/ReadBuilder.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core: Interface based DataFile reader and writer API [iceberg]

2025-04-10 Thread via GitHub
danielcweeks commented on code in PR #12298: URL: https://github.com/apache/iceberg/pull/12298#discussion_r2038209707 ## core/src/main/java/org/apache/iceberg/io/ReadBuilder.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core: Interface based DataFile reader and writer API [iceberg]

2025-04-10 Thread via GitHub
danielcweeks commented on code in PR #12298: URL: https://github.com/apache/iceberg/pull/12298#discussion_r2038207677 ## core/src/main/java/org/apache/iceberg/io/AppenderBuilder.java: ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Core: Interface based DataFile reader and writer API [iceberg]

2025-04-10 Thread via GitHub
danielcweeks commented on code in PR #12298: URL: https://github.com/apache/iceberg/pull/12298#discussion_r2038205281 ## core/src/main/java/org/apache/iceberg/io/AppenderBuilder.java: ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Core: Interface based DataFile reader and writer API [iceberg]

2025-04-10 Thread via GitHub
danielcweeks commented on code in PR #12298: URL: https://github.com/apache/iceberg/pull/12298#discussion_r2038204652 ## core/src/main/java/org/apache/iceberg/io/AppenderBuilder.java: ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Core: Interface based DataFile reader and writer API [iceberg]

2025-04-10 Thread via GitHub
westonpace commented on PR #12298: URL: https://github.com/apache/iceberg/pull/12298#issuecomment-2790138898 > Are you suggesting that we should use Arrow as an intermediate format? That is one way, and personally, I'd be a fan, but I wasn't sure it was practical or not in the code ba

Re: [PR] Core: Interface based DataFile reader and writer API [iceberg]

2025-04-09 Thread via GitHub
pvary commented on PR #12298: URL: https://github.com/apache/iceberg/pull/12298#issuecomment-2788854677 > Overall, +1 from me 🎉 > > I made a prototype Lance implementation here: [84bf5c5](https://github.com/apache/iceberg/commit/84bf5c53bc5ea19101bb7f21d72f24666c2b3804) @weston