Fokko commented on PR #10680:
URL: https://github.com/apache/iceberg/pull/10680#issuecomment-2225472776
Thanks for fixing this @boroknagyz , and thanks for the review
@ajantha-bhat, @jbonofre, @deniskuzZ and @nastra
--
This is an automated message from the Apache Git Service.
To respond
Fokko merged PR #10680:
URL: https://github.com/apache/iceberg/pull/10680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
Fokko commented on code in PR #10680:
URL: https://github.com/apache/iceberg/pull/10680#discussion_r1675638785
##
core/src/main/java/org/apache/iceberg/util/PartitionSet.java:
##
@@ -200,7 +200,7 @@ public String toString() {
StringBuilder partitionStringBuilder = new
nastra commented on code in PR #10680:
URL: https://github.com/apache/iceberg/pull/10680#discussion_r1675611984
##
core/src/main/java/org/apache/iceberg/util/PartitionSet.java:
##
@@ -200,7 +200,7 @@ public String toString() {
StringBuilder partitionStringBuilder = ne
Fokko commented on code in PR #10680:
URL: https://github.com/apache/iceberg/pull/10680#discussion_r1675562849
##
core/src/test/java/org/apache/iceberg/TestReplacePartitions.java:
##
@@ -67,6 +67,34 @@ public class TestReplacePartitions extends TestBase {
.withRecordC
Fokko commented on code in PR #10680:
URL: https://github.com/apache/iceberg/pull/10680#discussion_r1675557564
##
core/src/test/java/org/apache/iceberg/TestReplacePartitions.java:
##
@@ -67,6 +67,34 @@ public class TestReplacePartitions extends TestBase {
.withRecordC
nastra commented on code in PR #10680:
URL: https://github.com/apache/iceberg/pull/10680#discussion_r1675475160
##
core/src/test/java/org/apache/iceberg/TestReplacePartitions.java:
##
@@ -67,6 +67,34 @@ public class TestReplacePartitions extends TestBase {
.withRecord
jbonofre commented on PR #10680:
URL: https://github.com/apache/iceberg/pull/10680#issuecomment-2224915621
It looks good to me indeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ajantha-bhat commented on PR #10680:
URL: https://github.com/apache/iceberg/pull/10680#issuecomment-2224858353
Closing and repoening PR to trigger CI build. The current failure is
unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
ajantha-bhat closed pull request #10680: Core: Fix NPE during conflict handling
of NULL partitions
URL: https://github.com/apache/iceberg/pull/10680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
boroknagyz commented on code in PR #10680:
URL: https://github.com/apache/iceberg/pull/10680#discussion_r1674098559
##
core/src/main/java/org/apache/iceberg/util/PartitionSet.java:
##
@@ -200,7 +200,8 @@ public String toString() {
StringBuilder partitionStringBuilder
deniskuzZ commented on code in PR #10680:
URL: https://github.com/apache/iceberg/pull/10680#discussion_r1674048472
##
core/src/main/java/org/apache/iceberg/util/PartitionSet.java:
##
@@ -200,7 +200,8 @@ public String toString() {
StringBuilder partitionStringBuilder =
12 matches
Mail list logo
