Re: [PR] Core: Add internal Avro reader [iceberg]

2024-09-27 Thread via GitHub
aokolnychyi commented on code in PR #11108: URL: https://github.com/apache/iceberg/pull/11108#discussion_r1779299588 ## core/src/test/java/org/apache/iceberg/TestManifestReader.java: ## @@ -44,7 +44,8 @@ public class TestManifestReader extends TestBase { "fileOrdi

Re: [PR] Core: Add internal Avro reader [iceberg]

2024-09-27 Thread via GitHub
aokolnychyi commented on code in PR #11108: URL: https://github.com/apache/iceberg/pull/11108#discussion_r1779286019 ## core/src/main/java/org/apache/iceberg/ManifestReader.java: ## @@ -261,12 +262,12 @@ private CloseableIterable> open(Schema projection) { AvroIterable

Re: [PR] Core: Add internal Avro reader [iceberg]

2024-09-13 Thread via GitHub
rdblue commented on PR #11108: URL: https://github.com/apache/iceberg/pull/11108#issuecomment-2350721960 I've separated out the first commit as https://github.com/apache/iceberg/pull/11132. This still includes it but should merge cleanly if merged after #11132. -- This is an automated me