Re: [PR] Core: Add credentials to loadTable / loadView responses [iceberg]

2024-10-18 Thread via GitHub
nastra merged PR #11173: URL: https://github.com/apache/iceberg/pull/11173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Core: Add credentials to loadTable / loadView responses [iceberg]

2024-10-17 Thread via GitHub
nastra commented on code in PR #11173: URL: https://github.com/apache/iceberg/pull/11173#discussion_r1804920592 ## core/src/main/java/org/apache/iceberg/rest/credentials/CredentialParser.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Core: Add credentials to loadTable / loadView responses [iceberg]

2024-10-17 Thread via GitHub
nastra commented on code in PR #11173: URL: https://github.com/apache/iceberg/pull/11173#discussion_r1804920592 ## core/src/main/java/org/apache/iceberg/rest/credentials/CredentialParser.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Core: Add credentials to loadTable / loadView responses [iceberg]

2024-10-17 Thread via GitHub
amogh-jahagirdar commented on code in PR #11173: URL: https://github.com/apache/iceberg/pull/11173#discussion_r1804878848 ## core/src/main/java/org/apache/iceberg/rest/responses/LoadTableResponse.java: ## @@ -74,12 +83,17 @@ public Map config() { return config != null ? con

Re: [PR] Core: Add credentials to loadTable / loadView responses [iceberg]

2024-10-17 Thread via GitHub
amogh-jahagirdar commented on code in PR #11173: URL: https://github.com/apache/iceberg/pull/11173#discussion_r1804858493 ## core/src/main/java/org/apache/iceberg/rest/credentials/CredentialParser.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF)