Re: [PR] Changes to support string transform in add_field. [iceberg-python]

2025-04-19 Thread via GitHub
guptaakashdeep commented on code in PR #1936: URL: https://github.com/apache/iceberg-python/pull/1936#discussion_r2051557551 ## pyiceberg/transforms.py: ## @@ -111,29 +111,6 @@ def _transform_literal(func: Callable[[L], L], lit: Literal[L]) -> Literal[L]: return literal(fu

Re: [PR] Changes to support string transform in add_field. [iceberg-python]

2025-04-19 Thread via GitHub
kevinjqliu merged PR #1936: URL: https://github.com/apache/iceberg-python/pull/1936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [PR] Changes to support string transform in add_field. [iceberg-python]

2025-04-19 Thread via GitHub
kevinjqliu commented on PR #1936: URL: https://github.com/apache/iceberg-python/pull/1936#issuecomment-2816829704 Thanks @guptaakashdeep -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Changes to support string transform in add_field. [iceberg-python]

2025-04-19 Thread via GitHub
kevinjqliu commented on code in PR #1936: URL: https://github.com/apache/iceberg-python/pull/1936#discussion_r2051547823 ## pyiceberg/transforms.py: ## @@ -111,29 +111,6 @@ def _transform_literal(func: Callable[[L], L], lit: Literal[L]) -> Literal[L]: return literal(func(l

Re: [PR] Changes to support string transform in add_field. [iceberg-python]

2025-04-19 Thread via GitHub
guptaakashdeep commented on PR #1936: URL: https://github.com/apache/iceberg-python/pull/1936#issuecomment-2816695982 @Fokko Requesting review whenever you can. More details on changes I added in #1882 -- This is an automated message from the Apache Git Service. To respond to the message