Re: [PR] Build: Remove links checker [iceberg]

2024-06-09 Thread via GitHub
Fokko commented on PR #10404: URL: https://github.com/apache/iceberg/pull/10404#issuecomment-2156739145 @manuzhang Yes, I was out the last few days, thanks for pinging me 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Build: Remove links checker [iceberg]

2024-06-09 Thread via GitHub
Fokko merged PR #10404: URL: https://github.com/apache/iceberg/pull/10404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Build: Remove links checker [iceberg]

2024-06-09 Thread via GitHub
manuzhang commented on PR #10404: URL: https://github.com/apache/iceberg/pull/10404#issuecomment-2156657246 @Fokko Do you plan to merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Build: Remove links checker [iceberg]

2024-06-03 Thread via GitHub
Fokko commented on PR #10404: URL: https://github.com/apache/iceberg/pull/10404#issuecomment-2146176153 @manuzhang Good catch, that one was originally added by @bitsondatadev. Let's keep that one in, it works pretty well: ``` Downloaded: 345.3MB. Content types: 96 image, 19112 t

Re: [PR] Build: Remove links checker [iceberg]

2024-06-03 Thread via GitHub
manuzhang commented on PR #10404: URL: https://github.com/apache/iceberg/pull/10404#issuecomment-2145446188 @Fokko I'm good with leaving in the link checker, but we need to update the README which refers to another [python linkchecker](https://github.com/linkchecker/linkchecker). --

Re: [PR] Build: Remove links checker [iceberg]

2024-05-30 Thread via GitHub
Fokko commented on PR #10404: URL: https://github.com/apache/iceberg/pull/10404#issuecomment-2140004759 @manuzhang I was thinking of leaving in the link checker, but just removing it from the CI for now. You could still run it locally: https://github.com/apache/iceberg/tree/main/site#valida

Re: [PR] Build: Remove links checker [iceberg]

2024-05-30 Thread via GitHub
manuzhang commented on PR #10404: URL: https://github.com/apache/iceberg/pull/10404#issuecomment-2139851200 @Fokko we need to remove the config file as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov