Xuanwo commented on PR #850:
URL: https://github.com/apache/iceberg-rust/pull/850#issuecomment-2610097669
Thank you @gruuya for working on this, and thank you @Fokko, @kevinjqliu,
@liurenjie1024 and @sdd for the review. Sorry for the late, let's move!
--
This is an automated message from
Xuanwo merged PR #850:
URL: https://github.com/apache/iceberg-rust/pull/850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.a
sdd commented on PR #850:
URL: https://github.com/apache/iceberg-rust/pull/850#issuecomment-2606608614
It's a yes from me @gruuya - approved 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gruuya commented on PR #850:
URL: https://github.com/apache/iceberg-rust/pull/850#issuecomment-2606604978
Seems like we're close to consensus that this is merge-worthy. I take it
@sdd agrees, and I'm wondering are there any other objections? @Xuanwo
--
This is an automated message from t
gruuya commented on code in PR #850:
URL: https://github.com/apache/iceberg-rust/pull/850#discussion_r1914826504
##
crates/integration_tests/Cargo.toml:
##
@@ -27,9 +27,11 @@ rust-version = { workspace = true }
[dependencies]
arrow-array = { workspace = true }
arrow-schema =
sdd commented on code in PR #850:
URL: https://github.com/apache/iceberg-rust/pull/850#discussion_r1912758789
##
crates/integration_tests/Cargo.toml:
##
@@ -27,9 +27,11 @@ rust-version = { workspace = true }
[dependencies]
arrow-array = { workspace = true }
arrow-schema = { w
gruuya commented on code in PR #850:
URL: https://github.com/apache/iceberg-rust/pull/850#discussion_r1898355475
##
crates/integration_tests/tests/datafusion.rs:
##
@@ -0,0 +1,138 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license a
lewiszlw commented on code in PR #850:
URL: https://github.com/apache/iceberg-rust/pull/850#discussion_r1898282137
##
crates/integration_tests/tests/datafusion.rs:
##
@@ -0,0 +1,138 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
