Re: [PR] Add partition field/partition spec [iceberg-cpp]

2025-04-05 Thread via GitHub
wgtmac commented on code in PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54#discussion_r2021192486 ## src/iceberg/partition_spec.h: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] Add partition field/partition spec [iceberg-cpp]

2025-04-05 Thread via GitHub
gty404 commented on code in PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54#discussion_r2020974086 ## src/iceberg/transform.h: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the N

Re: [PR] Add partition field/partition spec [iceberg-cpp]

2025-03-31 Thread via GitHub
wgtmac commented on code in PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54#discussion_r2022059225 ## src/iceberg/CMakeLists.txt: ## @@ -23,7 +23,11 @@ set(ICEBERG_SOURCES schema.cc schema_field.cc schema_internal.cc -type.cc) +type.cc Review C

Re: [PR] Add partition field/partition spec [iceberg-cpp]

2025-03-31 Thread via GitHub
wgtmac commented on code in PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54#discussion_r2020465204 ## src/iceberg/partition_spec.h: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] Add partition field/partition spec [iceberg-cpp]

2025-03-31 Thread via GitHub
gty404 commented on code in PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54#discussion_r2021188186 ## src/iceberg/partition_spec.h: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] Add partition field/partition spec [iceberg-cpp]

2025-03-31 Thread via GitHub
yingcai-cy commented on code in PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54#discussion_r2020700206 ## src/iceberg/partition_spec.h: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements.

Re: [PR] Add partition field/partition spec [iceberg-cpp]

2025-03-31 Thread via GitHub
gty404 commented on code in PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54#discussion_r2020988663 ## src/iceberg/partition_field.h: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] Add partition field/partition spec [iceberg-cpp]

2025-03-31 Thread via GitHub
gty404 commented on code in PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54#discussion_r2020954814 ## src/iceberg/partition_field.h: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] Add partition field/partition spec [iceberg-cpp]

2025-03-31 Thread via GitHub
gty404 commented on code in PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54#discussion_r2020950011 ## src/iceberg/partition_spec.h: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] Add partition field/partition spec [iceberg-cpp]

2025-03-31 Thread via GitHub
gty404 commented on code in PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54#discussion_r2020948582 ## src/iceberg/partition_spec.h: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] Add partition field/partition spec [iceberg-cpp]

2025-03-31 Thread via GitHub
wgtmac commented on code in PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54#discussion_r2020695229 ## src/iceberg/partition_field.h: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] Add partition field/partition spec [iceberg-cpp]

2025-03-31 Thread via GitHub
yingcai-cy commented on code in PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54#discussion_r2020661687 ## src/iceberg/partition_field.h: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements.

Re: [PR] Add partition field/partition spec [iceberg-cpp]

2025-03-30 Thread via GitHub
wgtmac commented on code in PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54#discussion_r2020448679 ## src/iceberg/transform.h: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the N

Re: [PR] Add partition field/partition spec [iceberg-cpp]

2025-03-30 Thread via GitHub
lidavidm commented on code in PR #54: URL: https://github.com/apache/iceberg-cpp/pull/54#discussion_r2020381683 ## src/iceberg/partition_spec.h: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. Se