Re: [PR] Add license checker [iceberg-cpp]

2024-12-17 Thread via GitHub
raulcd commented on PR #10: URL: https://github.com/apache/iceberg-cpp/pull/10#issuecomment-254776 Thanks @zhjwpku , I've created: https://github.com/apache/iceberg-cpp/issues/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Add license checker [iceberg-cpp]

2024-12-17 Thread via GitHub
zhjwpku commented on PR #10: URL: https://github.com/apache/iceberg-cpp/pull/10#issuecomment-2547887458 > Thanks @raulcd @zhjwpku Let's add [pre-commit](https://pre-commit.com/) so we can add the [yaml format](https://pre-commit.com/hooks.html) hook to avoid manual formatting of yaml. Machi

Re: [PR] Add license checker [iceberg-cpp]

2024-12-17 Thread via GitHub
Fokko merged PR #10: URL: https://github.com/apache/iceberg-cpp/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] Add license checker [iceberg-cpp]

2024-12-17 Thread via GitHub
Fokko commented on PR #10: URL: https://github.com/apache/iceberg-cpp/pull/10#issuecomment-2547863756 Thanks @raulcd @zhjwpku Let's add [pre-commit](https://pre-commit.com/) so we can add the [yaml format](https://pre-commit.com/hooks.html) hook to avoid manual formatting of yaml. Machines

Re: [PR] Add license checker [iceberg-cpp]

2024-12-17 Thread via GitHub
zhjwpku commented on code in PR #10: URL: https://github.com/apache/iceberg-cpp/pull/10#discussion_r1888124750 ## .github/.licenserc.yaml: ## @@ -0,0 +1,16 @@ +header: + license: +spdx-id: Apache-2.0 +copyright-owner: Apache Software Foundation + + paths: +- '**' +

Re: [PR] Add license checker [iceberg-cpp]

2024-12-17 Thread via GitHub
zhjwpku commented on code in PR #10: URL: https://github.com/apache/iceberg-cpp/pull/10#discussion_r1888120102 ## .github/.licenserc.yaml: ## @@ -0,0 +1,16 @@ +header: + license: +spdx-id: Apache-2.0 +copyright-owner: Apache Software Foundation + + paths: +- '**' +

Re: [PR] Add license checker [iceberg-cpp]

2024-12-17 Thread via GitHub
zhjwpku commented on code in PR #10: URL: https://github.com/apache/iceberg-cpp/pull/10#discussion_r1888120102 ## .github/.licenserc.yaml: ## @@ -0,0 +1,16 @@ +header: + license: +spdx-id: Apache-2.0 +copyright-owner: Apache Software Foundation + + paths: +- '**' +

Re: [PR] Add license checker [iceberg-cpp]

2024-12-17 Thread via GitHub
Fokko commented on code in PR #10: URL: https://github.com/apache/iceberg-cpp/pull/10#discussion_r1888103438 ## .github/workflows/license_check.yml: ## @@ -0,0 +1,33 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] Add license checker [iceberg-cpp]

2024-12-16 Thread via GitHub
zhjwpku commented on code in PR #10: URL: https://github.com/apache/iceberg-cpp/pull/10#discussion_r1887940523 ## .github/workflows/license_check.yml: ## @@ -0,0 +1,33 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. Se

Re: [PR] Add license checker [iceberg-cpp]

2024-12-16 Thread via GitHub
zhjwpku commented on code in PR #10: URL: https://github.com/apache/iceberg-cpp/pull/10#discussion_r1887940523 ## .github/workflows/license_check.yml: ## @@ -0,0 +1,33 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. Se

Re: [PR] Add license checker [iceberg-cpp]

2024-12-16 Thread via GitHub
zhjwpku commented on code in PR #10: URL: https://github.com/apache/iceberg-cpp/pull/10#discussion_r1887922484 ## .github/.licenserc.yaml: ## @@ -0,0 +1,15 @@ +header: + license: +spdx-id: Apache-2.0 +copyright-owner: Apache Software Foundation + + paths: +- '**' +

Re: [PR] Add license checker [iceberg-cpp]

2024-12-16 Thread via GitHub
Fokko commented on code in PR #10: URL: https://github.com/apache/iceberg-cpp/pull/10#discussion_r1886494679 ## .github/workflows/license_check.yml: ## @@ -0,0 +1,26 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] Add license checker [iceberg-cpp]

2024-12-16 Thread via GitHub
Fokko commented on code in PR #10: URL: https://github.com/apache/iceberg-cpp/pull/10#discussion_r1886494679 ## .github/workflows/license_check.yml: ## @@ -0,0 +1,26 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] Add license checker [iceberg-cpp]

2024-12-16 Thread via GitHub
Fokko commented on code in PR #10: URL: https://github.com/apache/iceberg-cpp/pull/10#discussion_r1886489090 ## .github/workflows/license_check.yml: ## @@ -0,0 +1,26 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] Add license checker [iceberg-cpp]

2024-12-16 Thread via GitHub
raulcd commented on code in PR #10: URL: https://github.com/apache/iceberg-cpp/pull/10#discussion_r1886423651 ## .github/workflows/license_check.yml: ## @@ -0,0 +1,26 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] Add license checker [iceberg-cpp]

2024-12-15 Thread via GitHub
Fokko commented on code in PR #10: URL: https://github.com/apache/iceberg-cpp/pull/10#discussion_r1886325420 ## .github/workflows/license_check.yml: ## @@ -0,0 +1,26 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] Add license checker [iceberg-cpp]

2024-12-13 Thread via GitHub
wgtmac commented on code in PR #10: URL: https://github.com/apache/iceberg-cpp/pull/10#discussion_r1884080056 ## .github/workflows/license_check.yml: ## @@ -0,0 +1,26 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] Add license checker [iceberg-cpp]

2024-12-13 Thread via GitHub
zhjwpku commented on code in PR #10: URL: https://github.com/apache/iceberg-cpp/pull/10#discussion_r1883963124 ## dev/check-license: ## @@ -0,0 +1,83 @@ +#!/usr/bin/env bash + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements