Fokko commented on PR #7:
URL: https://github.com/apache/iceberg-cpp/pull/7#issuecomment-2541493436
Thanks @raulcd for the PR and thanks @wgtmac @gaborkaszab @pitrou for
reviewing. It seems like most of us are in agreement, and we can always
fine-tune later. I've merged this so this won't b
Fokko merged PR #7:
URL: https://github.com/apache/iceberg-cpp/pull/7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.
raulcd commented on code in PR #7:
URL: https://github.com/apache/iceberg-cpp/pull/7#discussion_r1883773249
##
.github/workflows/test.yml:
##
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE
raulcd commented on PR #7:
URL: https://github.com/apache/iceberg-cpp/pull/7#issuecomment-2541213585
Run is successful as seen here:
https://github.com/raulcd/iceberg-cpp/actions/runs/12314556083
@gaborkaszab @wgtmac if you are :+1: with this it probably can be merged
--
This is an
raulcd commented on code in PR #7:
URL: https://github.com/apache/iceberg-cpp/pull/7#discussion_r1878524143
##
.github/workflows/test.yml:
##
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE
pitrou commented on code in PR #7:
URL: https://github.com/apache/iceberg-cpp/pull/7#discussion_r1878396289
##
.github/workflows/test.yml:
##
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE
raulcd commented on code in PR #7:
URL: https://github.com/apache/iceberg-cpp/pull/7#discussion_r1878388213
##
.github/workflows/test.yml:
##
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE
gaborkaszab commented on code in PR #7:
URL: https://github.com/apache/iceberg-cpp/pull/7#discussion_r1878384745
##
.github/workflows/test.yml:
##
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the N
raulcd commented on code in PR #7:
URL: https://github.com/apache/iceberg-cpp/pull/7#discussion_r1877940138
##
.github/workflows/test.yml:
##
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE
raulcd commented on code in PR #7:
URL: https://github.com/apache/iceberg-cpp/pull/7#discussion_r1877940138
##
.github/workflows/test.yml:
##
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE
Fokko commented on code in PR #7:
URL: https://github.com/apache/iceberg-cpp/pull/7#discussion_r1877929785
##
.github/workflows/test.yml:
##
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE
Fokko commented on code in PR #7:
URL: https://github.com/apache/iceberg-cpp/pull/7#discussion_r1877928847
##
.github/workflows/test.yml:
##
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE
raulcd commented on code in PR #7:
URL: https://github.com/apache/iceberg-cpp/pull/7#discussion_r1877920379
##
.github/workflows/test.yml:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE
raulcd commented on code in PR #7:
URL: https://github.com/apache/iceberg-cpp/pull/7#discussion_r1877919831
##
.github/workflows/test.yml:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE
wgtmac commented on code in PR #7:
URL: https://github.com/apache/iceberg-cpp/pull/7#discussion_r1877496132
##
.github/workflows/test.yml:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE
raulcd commented on PR #7:
URL: https://github.com/apache/iceberg-cpp/pull/7#issuecomment-2527552348
I've validated actions run successfully on my fork:
https://github.com/raulcd/iceberg-cpp/actions/runs/12233865254
--
This is an automated message from the Apache Git Service.
To respond t
16 matches
Mail list logo