Re: [PR] Add an expireAfterWrite cache eviction policy to CachingCatalog [iceberg]

zhangminglei commented on code in PR #8844: URL: https://github.com/apache/iceberg/pull/8844#discussion_r1363068688 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestCachingCatalogExpirationAfterWrite.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software

Re: [PR] Add an expireAfterWrite cache eviction policy to CachingCatalog [iceberg]

nastra commented on code in PR #8844: URL: https://github.com/apache/iceberg/pull/8844#discussion_r1362413695 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestCachingCatalogExpirationAfterWrite.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Add an expireAfterWrite cache eviction policy to CachingCatalog [iceberg]

zhangminglei commented on code in PR #8844: URL: https://github.com/apache/iceberg/pull/8844#discussion_r1361733500 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestCachingCatalogExpirationAfterWrite.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software

Re: [PR] Add an expireAfterWrite cache eviction policy to CachingCatalog [iceberg]

lirui-apache commented on PR #8844: URL: https://github.com/apache/iceberg/pull/8844#issuecomment-1765657323 Thanks @zhangminglei for working on this. I guess we also need to update the doc in `CatalogProperties` to indicate the change. -- This is an automated message from the Apache Git

Re: [PR] Add an expireAfterWrite cache eviction policy to CachingCatalog [iceberg]

lirui-apache commented on code in PR #8844: URL: https://github.com/apache/iceberg/pull/8844#discussion_r1361499834 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestCachingCatalogExpirationAfterWrite.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software

Re: [PR] Add an expireAfterWrite cache eviction policy to CachingCatalog [iceberg]

zhangminglei commented on PR #8844: URL: https://github.com/apache/iceberg/pull/8844#issuecomment-1765624174 @nastra Thanks for your review, code updated done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Add an expireAfterWrite cache eviction policy to CachingCatalog [iceberg]

zhangminglei commented on code in PR #8844: URL: https://github.com/apache/iceberg/pull/8844#discussion_r1360798631 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestCachingCatalogExpirationAfterWrite.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed

Re: [PR] Add an expireAfterWrite cache eviction policy to CachingCatalog [iceberg]

zhangminglei commented on code in PR #8844: URL: https://github.com/apache/iceberg/pull/8844#discussion_r1360727462 ## core/src/main/java/org/apache/iceberg/CachingCatalog.java: ## @@ -110,6 +110,8 @@ private Cache createTableCache(Ticker ticker) { .removalListener(n

Re: [PR] Add an expireAfterWrite cache eviction policy to CachingCatalog [iceberg]

nastra commented on code in PR #8844: URL: https://github.com/apache/iceberg/pull/8844#discussion_r1360600506 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestCachingCatalogExpirationAfterWrite.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the

Re: [PR] Add an expireAfterWrite cache eviction policy to CachingCatalog [iceberg]

nastra commented on code in PR #8844: URL: https://github.com/apache/iceberg/pull/8844#discussion_r1360589867 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestCachingCatalogExpirationAfterWrite.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the

Re: [PR] Add an expireAfterWrite cache eviction policy to CachingCatalog [iceberg]

nastra commented on code in PR #8844: URL: https://github.com/apache/iceberg/pull/8844#discussion_r1360589513 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestCachingCatalogExpirationAfterWrite.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the

Re: [PR] Add an expireAfterWrite cache eviction policy to CachingCatalog [iceberg]

nastra commented on code in PR #8844: URL: https://github.com/apache/iceberg/pull/8844#discussion_r1360588962 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestCachingCatalogExpirationAfterWrite.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the

Re: [PR] Add an expireAfterWrite cache eviction policy to CachingCatalog [iceberg]

nastra commented on code in PR #8844: URL: https://github.com/apache/iceberg/pull/8844#discussion_r1360480900 ## core/src/main/java/org/apache/iceberg/CachingCatalog.java: ## @@ -110,6 +110,8 @@ private Cache createTableCache(Ticker ticker) { .removalListener(new Met

Re: [PR] Add an expireAfterWrite cache eviction policy to CachingCatalog [iceberg]

nastra commented on code in PR #8844: URL: https://github.com/apache/iceberg/pull/8844#discussion_r1360480900 ## core/src/main/java/org/apache/iceberg/CachingCatalog.java: ## @@ -110,6 +110,8 @@ private Cache createTableCache(Ticker ticker) { .removalListener(new Met