ZENOTME commented on code in PR #115:
URL: https://github.com/apache/iceberg-rust/pull/115#discussion_r1524152882
##
crates/iceberg/src/spec/sort.rs:
##
@@ -88,15 +91,106 @@ impl SortOrder {
pub fn is_unsorted(&self) -> bool {
self.fields.is_empty()
}
+
+/
Fokko merged PR #115:
URL: https://github.com/apache/iceberg-rust/pull/115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
liurenjie1024 commented on PR #115:
URL: https://github.com/apache/iceberg-rust/pull/115#issuecomment-1926133182
cc @Fokko Could we merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
liurenjie1024 commented on PR #115:
URL: https://github.com/apache/iceberg-rust/pull/115#issuecomment-1920612436
cc @Xuanwo @ZENOTME @Fokko PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
fqaiser94 commented on PR #115:
URL: https://github.com/apache/iceberg-rust/pull/115#issuecomment-1916069215
Found some time to look at this again :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
fqaiser94 commented on code in PR #115:
URL: https://github.com/apache/iceberg-rust/pull/115#discussion_r1470584482
##
crates/iceberg/src/spec/sort.rs:
##
@@ -88,15 +91,106 @@ impl SortOrder {
pub fn is_unsorted(&self) -> bool {
self.fields.is_empty()
}
+
+
fqaiser94 commented on PR #115:
URL: https://github.com/apache/iceberg-rust/pull/115#issuecomment-1899376623
@liurenjie1024 sorry, I think it might be a while before I get back to it.
Feel free to take it over/create a new PR if you'd like, I don't want to be
a blocker.
--
This is an
liurenjie1024 commented on PR #115:
URL: https://github.com/apache/iceberg-rust/pull/115#issuecomment-1898309586
cc @fqaiser94 Are you still working on this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
liurenjie1024 commented on code in PR #115:
URL: https://github.com/apache/iceberg-rust/pull/115#discussion_r1421922921
##
crates/iceberg/src/spec/sort.rs:
##
@@ -88,15 +91,106 @@ impl SortOrder {
pub fn is_unsorted(&self) -> bool {
self.fields.is_empty()
}
+
fqaiser94 commented on code in PR #115:
URL: https://github.com/apache/iceberg-rust/pull/115#discussion_r1421245396
##
crates/iceberg/src/spec/sort.rs:
##
@@ -88,15 +91,106 @@ impl SortOrder {
pub fn is_unsorted(&self) -> bool {
self.fields.is_empty()
}
+
+
fqaiser94 commented on code in PR #115:
URL: https://github.com/apache/iceberg-rust/pull/115#discussion_r1421245396
##
crates/iceberg/src/spec/sort.rs:
##
@@ -88,15 +91,106 @@ impl SortOrder {
pub fn is_unsorted(&self) -> bool {
self.fields.is_empty()
}
+
+
11 matches
Mail list logo
