Re: [PR] Add StrictMetricsEvaluator [iceberg-python]

2024-03-15 Thread via GitHub
Fokko commented on code in PR #518: URL: https://github.com/apache/iceberg-python/pull/518#discussion_r1525997387 ## pyiceberg/expressions/visitors.py: ## @@ -1421,3 +1430,299 @@ def visit_not_starts_with(self, term: BoundTerm[L], literal: Literal[L]) -> bool

Re: [PR] Add StrictMetricsEvaluator [iceberg-python]

2024-03-15 Thread via GitHub
Fokko commented on PR #518: URL: https://github.com/apache/iceberg-python/pull/518#issuecomment-1999270012 Thanks @HonahX for the review 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Add StrictMetricsEvaluator [iceberg-python]

2024-03-15 Thread via GitHub
Fokko merged PR #518: URL: https://github.com/apache/iceberg-python/pull/518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Add StrictMetricsEvaluator [iceberg-python]

2024-03-14 Thread via GitHub
HonahX commented on code in PR #518: URL: https://github.com/apache/iceberg-python/pull/518#discussion_r1525810853 ## pyiceberg/expressions/visitors.py: ## @@ -1421,3 +1430,299 @@ def visit_not_starts_with(self, term: BoundTerm[L], literal: Literal[L]) -> bool