Fokko commented on PR #87:
URL: https://github.com/apache/iceberg-python/pull/87#issuecomment-1777259485
@jayceslesar Thanks, there is no rush, appreciate it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
jayceslesar commented on PR #87:
URL: https://github.com/apache/iceberg-python/pull/87#issuecomment-1777174485
@Fokko I am definitely interested in adding it directly! Can look into this
next week
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
Fokko commented on PR #87:
URL: https://github.com/apache/iceberg-python/pull/87#issuecomment-1775119725
@jayceslesar It looks like that the ruff checker does not implement all the
rules. Are you interested in adding Refurb directly?
--
This is an automated message from the Apache Git Ser
Fokko closed pull request #87: Add Refurb to ruff
URL: https://github.com/apache/iceberg-python/pull/87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jayceslesar commented on PR #87:
URL: https://github.com/apache/iceberg-python/pull/87#issuecomment-1773176325
@Fokko running the latest version of refurb:
```
refurb pyiceberg
pyiceberg/avro/encoder.py:40:31 [FURB123]: Replace `bool(x)` with `x`
pyiceberg/avro/reader.py:354:16 [F
Fokko commented on PR #87:
URL: https://github.com/apache/iceberg-python/pull/87#issuecomment-1771655439
@jayceslesar Thanks for chiming in here. I believe that all checks are
enabled when the plugin is enabled. In the current codebase, there are no
violations. Enabling this will make sure
jayceslesar commented on PR #87:
URL: https://github.com/apache/iceberg-python/pull/87#issuecomment-1771566427
You might want to have a config here that enables and disables certain
checks but that can come with trial and error
--
This is an automated message from the Apache Git Service.
