Re: [PR] Add Python version 3.13 to test matrix. [iceberg-python]

2025-05-05 Thread via GitHub
kevinjqliu commented on PR #1377: URL: https://github.com/apache/iceberg-python/pull/1377#issuecomment-2851521593 Looks like 3.13 gave us some extra warnings > ResourceWarning: unclosed database in 52 failed, 2802 passed, 1093 deselected, 12 errors in 80.29s (0:01:20)

Re: [PR] Add Python version 3.13 to test matrix. [iceberg-python]

2025-05-04 Thread via GitHub
kevinjqliu commented on code in PR #1377: URL: https://github.com/apache/iceberg-python/pull/1377#discussion_r2072674445 ## pyproject.toml: ## Review Comment: can you also add 3.13 to the `classifiers` -- This is an automated message from the Apache Git Service. To res

Re: [PR] Add Python version 3.13 to test matrix. [iceberg-python]

2025-05-04 Thread via GitHub
kevinjqliu commented on code in PR #1377: URL: https://github.com/apache/iceberg-python/pull/1377#discussion_r2072674290 ## poetry.lock: ## @@ -1,4 +1,4 @@ -# This file is automatically @generated by Poetry 2.1.1 and should not be changed by hand. +# This file is automatically

Re: [PR] Add Python version 3.13 to test matrix. [iceberg-python]

2025-05-04 Thread via GitHub
JE-Chen commented on PR #1377: URL: https://github.com/apache/iceberg-python/pull/1377#issuecomment-2849296360 > You dont need to change the content of the poetry.lock file directly, its generated by running `poetry lock` after modifying the `pyproject.toml` file. > > Take a look at #

Re: [PR] Add Python version 3.13 to test matrix. [iceberg-python]

2025-05-04 Thread via GitHub
kevinjqliu commented on PR #1377: URL: https://github.com/apache/iceberg-python/pull/1377#issuecomment-2849294387 You dont need to change the content of the poetry.lock file directly, its generated by running `poetry lock` after modifying the `pyproject.toml` file. Take a look at htt

Re: [PR] Add Python version 3.13 to test matrix. [iceberg-python]

2025-05-03 Thread via GitHub
JE-Chen commented on PR #1377: URL: https://github.com/apache/iceberg-python/pull/1377#issuecomment-2849025597 Do I need to update this list? ![image](https://github.com/user-attachments/assets/5df35483-c40a-4f70-8351-cfa39b17792a) -- This is an automated message from the Apach

Re: [PR] Add Python version 3.13 to test matrix. [iceberg-python]

2025-05-03 Thread via GitHub
kevinjqliu commented on PR #1377: URL: https://github.com/apache/iceberg-python/pull/1377#issuecomment-2848893678 yep ray 2.45 has artifacts for python 3.13 https://pypi.org/project/ray/2.45.0/#files -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] Add Python version 3.13 to test matrix. [iceberg-python]

2025-05-03 Thread via GitHub
Fokko commented on PR #1377: URL: https://github.com/apache/iceberg-python/pull/1377#issuecomment-2848758717 @JE-Chen Could you do another attempt? We've bumped to Ray 2.45, but the issue is still open 🤔 -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] Add Python version 3.13 to test matrix. [iceberg-python]

2025-04-02 Thread via GitHub
Fokko commented on PR #1377: URL: https://github.com/apache/iceberg-python/pull/1377#issuecomment-2771772088 It looks like there is some progress: https://github.com/ray-project/ray/issues/49738#issuecomment-2755842804 We should also bump the upper bounds when generating the wheels:

Re: [PR] Add Python version 3.13 to test matrix. [iceberg-python]

2025-01-19 Thread via GitHub
kevinjqliu commented on PR #1377: URL: https://github.com/apache/iceberg-python/pull/1377#issuecomment-2601016186 Blocked on Ray 3.13 https://github.com/ray-project/ray/issues/49738 We can run `poetry update` after -- This is an automated message from the Apache Git Service. To res

Re: [PR] Add Python version 3.13 to test matrix. [iceberg-python]

2025-01-15 Thread via GitHub
Fokko commented on PR #1377: URL: https://github.com/apache/iceberg-python/pull/1377#issuecomment-2593287814 Fixing conflicts to see where we are with 3.13 :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Add Python version 3.13 to test matrix. [iceberg-python]

2024-12-20 Thread via GitHub
Fokko commented on PR #1377: URL: https://github.com/apache/iceberg-python/pull/1377#issuecomment-2557103041 ``` at ~/.local/lib/python3.10/site-packages/poetry/installation/chef.py:164 in _prepare 160│ 161│ error = ChefBuildError("\n\n".join(message_p

Re: [PR] Add Python version 3.13 to test matrix. [iceberg-python]

2024-12-20 Thread via GitHub
Fokko commented on PR #1377: URL: https://github.com/apache/iceberg-python/pull/1377#issuecomment-2557096798 @JE-Chen I think it pulls `pyo3` in when it can't find pre-build wheels for a combination of the Python version and architecture. -- This is an automated message from the Apache Gi

Re: [PR] Add Python version 3.13 to test matrix. [iceberg-python]

2024-11-27 Thread via GitHub
JE-Chen commented on PR #1377: URL: https://github.com/apache/iceberg-python/pull/1377#issuecomment-2504060362 Currently, we are using pyo3 v0.20.3. I think only versions of pyo3 v0.21 or newer support Python 3.13. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Add Python version 3.13 to test matrix. [iceberg-python]

2024-11-26 Thread via GitHub
JE-Chen commented on PR #1377: URL: https://github.com/apache/iceberg-python/pull/1377#issuecomment-2503058477 Same error. ``` error: the configured Python interpreter version (3.13) is newer than PyO3's maximum supported version (3.12) ``` -- This is an automated message from th

Re: [PR] Add Python version 3.13 to test matrix. [iceberg-python]

2024-11-26 Thread via GitHub
Fokko commented on PR #1377: URL: https://github.com/apache/iceberg-python/pull/1377#issuecomment-2501858847 @JE-Chen Thanks for checking. It looks like Py3O is already at 3.13: https://github.com/PyO3/pyo3/issues/4636 I was hoping that maybe bumping the Poetry build might fix it https://gi

Re: [PR] Add Python version 3.13 to test matrix. [iceberg-python]

2024-11-26 Thread via GitHub
JE-Chen commented on PR #1377: URL: https://github.com/apache/iceberg-python/pull/1377#issuecomment-2500736509 ``` error: the configured Python interpreter version (3.13) is newer than PyO3's maximum supported version (3.12) ``` -- This is an automated message from the Apache Git S