Re: [PR] Add Hive integration tests [iceberg-python]

2024-01-17 Thread via GitHub
Fokko merged PR #207: URL: https://github.com/apache/iceberg-python/pull/207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Add Hive integration tests [iceberg-python]

2024-01-17 Thread via GitHub
Fokko commented on PR #207: URL: https://github.com/apache/iceberg-python/pull/207#issuecomment-1896052914 Thanks @HonahX for the review 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Add Hive integration tests [iceberg-python]

2024-01-17 Thread via GitHub
Fokko commented on code in PR #207: URL: https://github.com/apache/iceberg-python/pull/207#discussion_r1455755578 ## tests/integration/test_hive.py: ## @@ -0,0 +1,409 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] Add Hive integration tests [iceberg-python]

2023-12-14 Thread via GitHub
HonahX commented on code in PR #207: URL: https://github.com/apache/iceberg-python/pull/207#discussion_r1427569648 ## tests/integration/test_hive.py: ## @@ -0,0 +1,409 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. Se

Re: [PR] Add Hive integration tests [iceberg-python]

2023-12-14 Thread via GitHub
HonahX commented on code in PR #207: URL: https://github.com/apache/iceberg-python/pull/207#discussion_r1427569648 ## tests/integration/test_hive.py: ## @@ -0,0 +1,409 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. Se

Re: [PR] Add Hive integration tests [iceberg-python]

2023-12-14 Thread via GitHub
HonahX commented on code in PR #207: URL: https://github.com/apache/iceberg-python/pull/207#discussion_r1427591155 ## tests/integration/__init__.py: ## @@ -0,0 +1,16 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] Add Hive integration tests [iceberg-python]

2023-12-14 Thread via GitHub
HonahX commented on code in PR #207: URL: https://github.com/apache/iceberg-python/pull/207#discussion_r1427591155 ## tests/integration/__init__.py: ## @@ -0,0 +1,16 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] Add Hive integration tests [iceberg-python]

2023-12-14 Thread via GitHub
HonahX commented on code in PR #207: URL: https://github.com/apache/iceberg-python/pull/207#discussion_r1427569648 ## tests/integration/test_hive.py: ## @@ -0,0 +1,409 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. Se

Re: [PR] Add Hive integration tests [iceberg-python]

2023-12-14 Thread via GitHub
Fokko commented on code in PR #207: URL: https://github.com/apache/iceberg-python/pull/207#discussion_r1427172141 ## dev/Dockerfile: ## @@ -62,7 +60,7 @@ RUN chmod u+x /opt/spark/sbin/* && \ RUN pip3 install -q ipython -RUN pip3 install "pyiceberg[s3fs]==${PYICEBERG_VERSION

Re: [PR] Add Hive integration tests [iceberg-python]

2023-12-14 Thread via GitHub
Fokko commented on code in PR #207: URL: https://github.com/apache/iceberg-python/pull/207#discussion_r1427153974 ## tests/integration/test_hive.py: ## @@ -0,0 +1,409 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] Add Hive integration tests [iceberg-python]

2023-12-14 Thread via GitHub
Fokko commented on code in PR #207: URL: https://github.com/apache/iceberg-python/pull/207#discussion_r1427150320 ## tests/integration/__init__.py: ## @@ -0,0 +1,16 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See t

Re: [PR] Add Hive integration tests [iceberg-python]

2023-12-14 Thread via GitHub
HonahX commented on code in PR #207: URL: https://github.com/apache/iceberg-python/pull/207#discussion_r1426357825 ## tests/integration/test_hive.py: ## @@ -0,0 +1,409 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. Se

Re: [PR] Add Hive integration tests [iceberg-python]

2023-12-14 Thread via GitHub
HonahX commented on code in PR #207: URL: https://github.com/apache/iceberg-python/pull/207#discussion_r1426280842 ## tests/integration/__init__.py: ## @@ -0,0 +1,16 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] Add Hive integration tests [iceberg-python]

2023-12-14 Thread via GitHub
HonahX commented on code in PR #207: URL: https://github.com/apache/iceberg-python/pull/207#discussion_r1426357825 ## tests/integration/test_hive.py: ## @@ -0,0 +1,409 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. Se