Fokko merged PR #355:
URL: https://github.com/apache/iceberg-python/pull/355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko commented on PR #355:
URL: https://github.com/apache/iceberg-python/pull/355#issuecomment-1928918841
@jaychia Recently Hive integration tests have been added. First, you want to
make sure that you're on a recent version of Docker. Also, it is good to
periodically run `make test-integr
jaychia commented on PR #355:
URL: https://github.com/apache/iceberg-python/pull/355#issuecomment-1928068519
> Should we also have some sanity checks, for example:
>
>
https://github.com/apache/iceberg-python/blob/a4856bc2eadf90ac85dec96d4502ca3517bb1bb5/tests/integration/test_reads.p
jaychia commented on code in PR #355:
URL: https://github.com/apache/iceberg-python/pull/355#discussion_r1478653195
##
pyproject.toml:
##
@@ -105,6 +105,7 @@ pyarrow = ["pyarrow"]
pandas = ["pandas", "pyarrow"]
duckdb = ["duckdb", "pyarrow"]
ray = ["ray", "pyarrow", "pandas"]
Fokko commented on PR #355:
URL: https://github.com/apache/iceberg-python/pull/355#issuecomment-1925918588
Should we also have some sanity checks, for example:
https://github.com/apache/iceberg-python/blob/a4856bc2eadf90ac85dec96d4502ca3517bb1bb5/tests/integration/test_reads.py#L184
--
Th
Fokko commented on code in PR #355:
URL: https://github.com/apache/iceberg-python/pull/355#discussion_r1477436119
##
pyproject.toml:
##
@@ -105,6 +105,7 @@ pyarrow = ["pyarrow"]
pandas = ["pandas", "pyarrow"]
duckdb = ["duckdb", "pyarrow"]
ray = ["ray", "pyarrow", "pandas"]
+
