Re: [PR] Accept date in literal [iceberg-python]

2025-02-08 Thread via GitHub
Fokko commented on PR #1618: URL: https://github.com/apache/iceberg-python/pull/1618#issuecomment-2645566072 Thanks @TennyZhuang for adding this, and thanks @kevinjqliu for the review 🙌 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] Accept date in literal [iceberg-python]

2025-02-08 Thread via GitHub
Fokko merged PR #1618: URL: https://github.com/apache/iceberg-python/pull/1618 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Accept date in literal [iceberg-python]

2025-02-08 Thread via GitHub
Fokko commented on PR #1618: URL: https://github.com/apache/iceberg-python/pull/1618#issuecomment-2645478647 @TennyZhuang That looks unrelated to your PR, I've restarted the job -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Accept date in literal [iceberg-python]

2025-02-08 Thread via GitHub
TennyZhuang commented on PR #1618: URL: https://github.com/apache/iceberg-python/pull/1618#issuecomment-2645345620 I have no idea why the CI failed again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] Accept date in literal [iceberg-python]

2025-02-07 Thread via GitHub
Fokko commented on PR #1618: URL: https://github.com/apache/iceberg-python/pull/1618#issuecomment-264280 @TennyZhuang Can you run `make lint`? There seems to be a formatting issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Accept date in literal [iceberg-python]

2025-02-06 Thread via GitHub
Fokko commented on code in PR #1618: URL: https://github.com/apache/iceberg-python/pull/1618#discussion_r1944881417 ## pyiceberg/expressions/literals.py: ## @@ -149,6 +150,8 @@ def literal(value: L) -> Literal[L]: return DecimalLiteral(value) elif isinstance(value,