Re: [PR] API, Core: Fix naming in fastForwardBranch/replaceBranch APIs [iceberg]

amogh-jahagirdar commented on PR #9134: URL: https://github.com/apache/iceberg/pull/9134#issuecomment-1828471872 Merging, thanks for the reviews @nastra @rakesh-das08 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] API, Core: Fix naming in fastForwardBranch/replaceBranch APIs [iceberg]

amogh-jahagirdar merged PR #9134: URL: https://github.com/apache/iceberg/pull/9134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] API, Core: Fix naming in fastForwardBranch/replaceBranch APIs [iceberg]

amogh-jahagirdar commented on code in PR #9134: URL: https://github.com/apache/iceberg/pull/9134#discussion_r1406602865 ## core/src/main/java/org/apache/iceberg/UpdateSnapshotReferencesOperation.java: ## @@ -106,40 +106,41 @@ public UpdateSnapshotReferencesOperation replaceBran

Re: [PR] API, Core: Fix naming in fastForwardBranch/replaceBranch APIs [iceberg]

nastra commented on code in PR #9134: URL: https://github.com/apache/iceberg/pull/9134#discussion_r1406496932 ## core/src/main/java/org/apache/iceberg/UpdateSnapshotReferencesOperation.java: ## @@ -106,40 +106,41 @@ public UpdateSnapshotReferencesOperation replaceBranch(String

Re: [PR] API, Core: Fix naming in fastForwardBranch/replaceBranch APIs [iceberg]

amogh-jahagirdar commented on code in PR #9134: URL: https://github.com/apache/iceberg/pull/9134#discussion_r1405269661 ## core/src/main/java/org/apache/iceberg/UpdateSnapshotReferencesOperation.java: ## @@ -106,40 +106,42 @@ public UpdateSnapshotReferencesOperation replaceBran

Re: [PR] API, Core: Fix naming in fastForwardBranch/replaceBranch APIs [iceberg]

amogh-jahagirdar commented on code in PR #9134: URL: https://github.com/apache/iceberg/pull/9134#discussion_r1405269605 ## core/src/test/java/org/apache/iceberg/TestSnapshotManager.java: ## @@ -427,6 +427,26 @@ public void testReplaceBranchNonExistingSourceFails() { .ha

Re: [PR] API, Core: Fix naming in fastForwardBranch/replaceBranch APIs [iceberg]

nastra commented on code in PR #9134: URL: https://github.com/apache/iceberg/pull/9134#discussion_r1403006302 ## core/src/main/java/org/apache/iceberg/UpdateSnapshotReferencesOperation.java: ## @@ -106,40 +106,42 @@ public UpdateSnapshotReferencesOperation replaceBranch(String

Re: [PR] API, Core: Fix naming in fastForwardBranch/replaceBranch APIs [iceberg]

nastra commented on code in PR #9134: URL: https://github.com/apache/iceberg/pull/9134#discussion_r1403004798 ## core/src/test/java/org/apache/iceberg/TestSnapshotManager.java: ## @@ -427,6 +427,26 @@ public void testReplaceBranchNonExistingSourceFails() { .hasMessage("

Re: [PR] API, Core: Fix naming in fastForwardBranch/replaceBranch APIs [iceberg]

amogh-jahagirdar commented on code in PR #9134: URL: https://github.com/apache/iceberg/pull/9134#discussion_r1402854044 ## api/src/main/java/org/apache/iceberg/ManageSnapshots.java: ## @@ -163,26 +163,26 @@ default ManageSnapshots createBranch(String name) { ManageSnapshots r

Re: [PR] API, Core: Fix naming in fastForwardBranch/replaceBranch APIs [iceberg]

amogh-jahagirdar commented on code in PR #9134: URL: https://github.com/apache/iceberg/pull/9134#discussion_r1402845199 ## api/src/main/java/org/apache/iceberg/ManageSnapshots.java: ## @@ -163,26 +163,26 @@ default ManageSnapshots createBranch(String name) { ManageSnapshots r

Re: [PR] API, Core: Fix naming in fastForwardBranch/replaceBranch APIs [iceberg]

amogh-jahagirdar commented on code in PR #9134: URL: https://github.com/apache/iceberg/pull/9134#discussion_r1402845199 ## api/src/main/java/org/apache/iceberg/ManageSnapshots.java: ## @@ -163,26 +163,26 @@ default ManageSnapshots createBranch(String name) { ManageSnapshots r

Re: [PR] API, Core: Fix naming in fastForwardBranch/replaceBranch APIs [iceberg]

rakesh-das08 commented on code in PR #9134: URL: https://github.com/apache/iceberg/pull/9134#discussion_r1402838230 ## api/src/main/java/org/apache/iceberg/ManageSnapshots.java: ## @@ -163,26 +163,26 @@ default ManageSnapshots createBranch(String name) { ManageSnapshots repla

Re: [PR] API, Core: Fix naming in fastForwardBranch/replaceBranch APIs [iceberg]

amogh-jahagirdar commented on code in PR #9134: URL: https://github.com/apache/iceberg/pull/9134#discussion_r1402641790 ## api/src/main/java/org/apache/iceberg/ManageSnapshots.java: ## @@ -163,26 +163,26 @@ default ManageSnapshots createBranch(String name) { ManageSnapshots r

Re: [PR] API, Core: Fix naming in fastForwardBranch/replaceBranch APIs [iceberg]

amogh-jahagirdar commented on code in PR #9134: URL: https://github.com/apache/iceberg/pull/9134#discussion_r1402637674 ## core/src/test/java/org/apache/iceberg/TestSnapshotManager.java: ## @@ -427,6 +427,26 @@ public void testReplaceBranchNonExistingSourceFails() { .ha

Re: [PR] API, Core: Fix naming in fastForwardBranch/replaceBranch APIs [iceberg]

amogh-jahagirdar commented on PR #9134: URL: https://github.com/apache/iceberg/pull/9134#issuecomment-1823395448 cc @rakesh-das08 This stems from our discussion on https://github.com/apache/iceberg/pull/8854#discussion_r1361985873 -- This is an automated message from the Apache Git Servi