Re: [PR] [Bug Fix] all TimeTransforms for falsey values [iceberg-python]

2024-01-18 Thread via GitHub
HonahX merged PR #280: URL: https://github.com/apache/iceberg-python/pull/280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] [Bug Fix] all TimeTransforms for falsey values [iceberg-python]

2024-01-18 Thread via GitHub
HonahX commented on PR #280: URL: https://github.com/apache/iceberg-python/pull/280#issuecomment-1899486620 @syun64 Sorry I was interrupted by other things. Merging! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [Bug Fix] all TimeTransforms for falsey values [iceberg-python]

2024-01-18 Thread via GitHub
syun64 commented on PR #280: URL: https://github.com/apache/iceberg-python/pull/280#issuecomment-1899239713 Thank you for the reviews @Fokko @HonahX . Could I ask for your help in merging it in? :) -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] [Bug Fix] all TimeTransforms for falsey values [iceberg-python]

2024-01-18 Thread via GitHub
syun64 commented on PR #280: URL: https://github.com/apache/iceberg-python/pull/280#issuecomment-1899177736 of course! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Bug Fix] all TimeTransforms for falsey values [iceberg-python]

2024-01-18 Thread via GitHub
Fokko commented on PR #280: URL: https://github.com/apache/iceberg-python/pull/280#issuecomment-1899176368 @syun64 The other PR is in 👍 Can you rebase? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] [Bug Fix] all TimeTransforms for falsey values [iceberg-python]

2024-01-18 Thread via GitHub
syun64 commented on PR #280: URL: https://github.com/apache/iceberg-python/pull/280#issuecomment-1899173158 No problem, and thank you! :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [Bug Fix] all TimeTransforms for falsey values [iceberg-python]

2024-01-18 Thread via GitHub
Fokko commented on PR #280: URL: https://github.com/apache/iceberg-python/pull/280#issuecomment-1899169134 @syun64 Thanks, let me poke someone to get it in 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [Bug Fix] all TimeTransforms for falsey values [iceberg-python]

2024-01-18 Thread via GitHub
syun64 commented on PR #280: URL: https://github.com/apache/iceberg-python/pull/280#issuecomment-1899161809 CI failure related to: https://github.com/apache/iceberg-python/pull/279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH