github-actions[bot] commented on PR #10284:
URL: https://github.com/apache/iceberg/pull/10284#issuecomment-2465928481
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If
github-actions[bot] closed pull request #10284: #10275 - fix
NullPointerException
URL: https://github.com/apache/iceberg/pull/10284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
github-actions[bot] commented on PR #10284:
URL: https://github.com/apache/iceberg/pull/10284#issuecomment-2452745532
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
slessard commented on code in PR #10284:
URL: https://github.com/apache/iceberg/pull/10284#discussion_r1640138994
##
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java:
##
@@ -263,6 +265,60 @@ public void testReadColumnFilter2() throws Exception {
slessard commented on code in PR #10284:
URL: https://github.com/apache/iceberg/pull/10284#discussion_r1640138360
##
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java:
##
@@ -263,6 +265,60 @@ public void testReadColumnFilter2() throws Exception {
slessard commented on code in PR #10284:
URL: https://github.com/apache/iceberg/pull/10284#discussion_r1640137631
##
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java:
##
@@ -263,6 +265,60 @@ public void testReadColumnFilter2() throws Exception {
nastra commented on code in PR #10284:
URL: https://github.com/apache/iceberg/pull/10284#discussion_r1639862391
##
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java:
##
@@ -263,6 +265,60 @@ public void testReadColumnFilter2() throws Exception {
nastra commented on code in PR #10284:
URL: https://github.com/apache/iceberg/pull/10284#discussion_r1639863717
##
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java:
##
@@ -263,6 +265,60 @@ public void testReadColumnFilter2() throws Exception {
nastra commented on code in PR #10284:
URL: https://github.com/apache/iceberg/pull/10284#discussion_r1639863416
##
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java:
##
@@ -263,6 +265,60 @@ public void testReadColumnFilter2() throws Exception {
nastra commented on code in PR #10284:
URL: https://github.com/apache/iceberg/pull/10284#discussion_r1639868640
##
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java:
##
@@ -263,6 +265,60 @@ public void testReadColumnFilter2() throws Exception {
nastra commented on code in PR #10284:
URL: https://github.com/apache/iceberg/pull/10284#discussion_r1639866342
##
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java:
##
@@ -263,6 +265,60 @@ public void testReadColumnFilter2() throws Exception {
nastra commented on code in PR #10284:
URL: https://github.com/apache/iceberg/pull/10284#discussion_r1639862872
##
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java:
##
@@ -263,6 +265,60 @@ public void testReadColumnFilter2() throws Exception {
slessard commented on PR #10284:
URL: https://github.com/apache/iceberg/pull/10284#issuecomment-2161712697
@nastra I've added a new unit test in
iceberg/arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java.
I believe / hope this new unit tests satisfies your requirem
slessard commented on PR #10284:
URL: https://github.com/apache/iceberg/pull/10284#issuecomment-2161448440
@nastra I believe the bug I am trying to fix is associated with Arrow
readers, not Spark readers. The file in which you requested I add a unit test
is specific to Spark. Is there a pla
nastra commented on PR #10284:
URL: https://github.com/apache/iceberg/pull/10284#issuecomment-2102639635
I think it would be good to add a test that reproduces the issue you
described in `TestParquetVectorizedReads`
--
This is an automated message from the Apache Git Service.
To respond t
slessard commented on code in PR #10284:
URL: https://github.com/apache/iceberg/pull/10284#discussion_r1594328291
##
build.gradle:
##
@@ -840,6 +840,8 @@ project(':iceberg-arrow') {
exclude group: 'org.codehaus.jackson'
}
+testImplementation 'org.apache.spark:s
slessard commented on code in PR #10284:
URL: https://github.com/apache/iceberg/pull/10284#discussion_r1594303461
##
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/GenericArrowVectorAccessorFactoryTest.java:
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Fo
nastra commented on code in PR #10284:
URL: https://github.com/apache/iceberg/pull/10284#discussion_r1594003789
##
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/GenericArrowVectorAccessorFactoryTest.java:
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foun
nastra commented on code in PR #10284:
URL: https://github.com/apache/iceberg/pull/10284#discussion_r1594002633
##
build.gradle:
##
@@ -840,6 +840,8 @@ project(':iceberg-arrow') {
exclude group: 'org.codehaus.jackson'
}
+testImplementation 'org.apache.spark:spa
19 matches
Mail list logo
