Re: [I] Support loading custom catalog implementation [iceberg-python]

2024-07-25 Thread via GitHub
kevinjqliu closed issue #938: Support loading custom catalog implementation URL: https://github.com/apache/iceberg-python/issues/938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [I] Support loading custom catalog implementation [iceberg-python]

2024-07-23 Thread via GitHub
kevinjqliu commented on issue #938: URL: https://github.com/apache/iceberg-python/issues/938#issuecomment-2245770537 I think behavior checking for custom catalogs is a nice-to-have feature, but ultimately it is up to the implementation to make sure the catalog behaves correctly. That sai

Re: [I] Support loading custom catalog implementation [iceberg-python]

2024-07-22 Thread via GitHub
jayceslesar commented on issue #938: URL: https://github.com/apache/iceberg-python/issues/938#issuecomment-2244127116 Would it hurt to add some checks to the custom catalog implementation passed in to ensure that a core suite of methods are provided in the custom implementation? I can imag

Re: [I] Support loading custom catalog implementation [iceberg-python]

2024-07-19 Thread via GitHub
jackye1995 commented on issue #938: URL: https://github.com/apache/iceberg-python/issues/938#issuecomment-2240876786 I can give a try for it, assigning to myself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] Support loading custom catalog implementation [iceberg-python]

2024-07-19 Thread via GitHub
Fokko commented on issue #938: URL: https://github.com/apache/iceberg-python/issues/938#issuecomment-2239864983 Yes, I think that would be a nice addition. As Jack already pointed out, we already have dynamic loading of file-io's using `py-io-impl`, so loading a catalog would be relatively

Re: [I] Support loading custom catalog implementation [iceberg-python]

2024-07-17 Thread via GitHub
HonahX commented on issue #938: URL: https://github.com/apache/iceberg-python/issues/938#issuecomment-2235570532 > But maybe there is value allowing load_catalog to parse properties for custom catalogs for ease of use. +1. I think it is beneficial for `load_catalog` to support additio

Re: [I] Support loading custom catalog implementation [iceberg-python]

2024-07-17 Thread via GitHub
syun64 commented on issue #938: URL: https://github.com/apache/iceberg-python/issues/938#issuecomment-2234935944 Hi @jackye1995 - I'm of the opinion that this is totally fine. If the client wants to have their own catalog implementation for any of many possible reasons (e.g. because it requ

Re: [I] Support loading custom catalog implementation [iceberg-python]

2024-07-17 Thread via GitHub
jackye1995 commented on issue #938: URL: https://github.com/apache/iceberg-python/issues/938#issuecomment-2233756541 cc @Fokko @HonahX @syun64 @kevinjqliu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above