flyrain commented on issue #463:
URL: https://github.com/apache/iceberg-python/issues/463#issuecomment-1979651924
Closed. Thanks @danielcweeks and @syun64 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
flyrain closed issue #463: Support OAuth2 Client credential flow
URL: https://github.com/apache/iceberg-python/issues/463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
syun64 commented on issue #463:
URL: https://github.com/apache/iceberg-python/issues/463#issuecomment-1979175057
Given that we've confirmed that Client Credentials flow is already
supported, and we've fixed the current model to make attributes optional, is
this issue good to close @flyrain
flyrain commented on issue #463:
URL: https://github.com/apache/iceberg-python/issues/463#issuecomment-1960507583
`token_type` are required by both flows in RFC. It is fine to be mandatory
for both. The problem is the `issued_token_type`, The token exchange flow
[RFC](https://datatracker.ie
danielcweeks commented on issue #463:
URL: https://github.com/apache/iceberg-python/issues/463#issuecomment-1960499113
According to the
[RFC](https://datatracker.ietf.org/doc/html/rfc6749#section-4.4.3) it should be
`token_type`, but we currently only support `bearer`. The exchange does wo
flyrain commented on issue #463:
URL: https://github.com/apache/iceberg-python/issues/463#issuecomment-1960485657
The client credential flow doesn't return a field `issued_token_type`.
PyIceberg failed at validation:
```
ValidationError: 1 validation error for TokenResponse
issued_
danielcweeks commented on issue #463:
URL: https://github.com/apache/iceberg-python/issues/463#issuecomment-1960467569
The client credential flow is already implemented: [see
here](https://github.com/apache/iceberg-python/blob/82d88920aaa7cba8593e93b5df9f3a87b13c88da/pyiceberg/catalog/rest.p
