huyuanfeng2018 commented on issue #9349:
URL: https://github.com/apache/iceberg/issues/9349#issuecomment-2164217430
> @huyuanfeng2018 Is there a way this can be closed? I see in other catalog
files you have made changes so that close method is called.
I think this depends on spark. Sp
allen-abhishekkr commented on issue #9349:
URL: https://github.com/apache/iceberg/issues/9349#issuecomment-2163881242
@huyuanfeng2018 Is there a way this can be closed? I see in other catalog
files you have made changes so that close method is called.
--
This is an automated message from
huyuanfeng2018 commented on issue #9349:
URL: https://github.com/apache/iceberg/issues/9349#issuecomment-2162903308
> @huyuanfeng2018
>
> I see that the "closeable" trait was added in this commit, however in case
of below implementations, the close() method of the MetricsReporter neve
allen-abhishekkr commented on issue #9349:
URL: https://github.com/apache/iceberg/issues/9349#issuecomment-2153099416
@huyuanfeng2018
I see that the "closeable" trait was added in this commit, however in case
of below implementations, the close() method of the MetricsReporter never g
huyuanfeng2018 closed issue #9349: MetricsReporter support close
URL: https://github.com/apache/iceberg/issues/9349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
huyuanfeng2018 commented on issue #9349:
URL: https://github.com/apache/iceberg/issues/9349#issuecomment-1864110863
> I think making `MetricsReporter` closeable makes sense. It would have to
be closed when the catalog is being closed. Can you open a PR and I'll take a
look?
OK, I wil
nastra commented on issue #9349:
URL: https://github.com/apache/iceberg/issues/9349#issuecomment-1864076058
I think making `MetricsReporter` closeable makes sense. It would have to be
closed when the catalog is being closed. Can you open a PR and I'll take a look?
--
This is an automated
