matthijseikelenboom commented on issue #10454:
URL: https://github.com/apache/iceberg/issues/10454#issuecomment-2167457284
Closing as this has been resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
matthijseikelenboom closed issue #10454: Iceberg fails ACID verification test
URL: https://github.com/apache/iceberg/issues/10454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
matthijseikelenboom commented on issue #10454:
URL: https://github.com/apache/iceberg/issues/10454#issuecomment-2155244734
Oh wow, I'll take this back to the team at work! Thanks for taking the time,
but my issue wasn't important enough to not go to sleep I think 😅.
About the unit tes
RussellSpitzer commented on issue #10454:
URL: https://github.com/apache/iceberg/issues/10454#issuecomment-2155166332
I fixed all your bugs and the test now passes. I would strongly encourage
you to write unit tests for frameworks like this to make sure they behave
correctly before asking o
RussellSpitzer commented on issue #10454:
URL: https://github.com/apache/iceberg/issues/10454#issuecomment-2155158031
The Delete verification is also wrong
```
var deleteSucceededExpectation =
ExpectRecordPresence.create(recordToDelete);
```
This should be ExpectedRec
RussellSpitzer commented on issue #10454:
URL: https://github.com/apache/iceberg/issues/10454#issuecomment-2155151614
I didn't go to sleep, here is the error. This is what your delete statements
look like:
```
DELETE FROM iceberghive.concurrencytestdb.acid_verification WHERE
prima
RussellSpitzer commented on issue #10454:
URL: https://github.com/apache/iceberg/issues/10454#issuecomment-2155075202
I am pretty sure it’s the delete statement failing but I’m too tired, just
got back to my house, to figure out why.
--
This is an automated message from the Apache Git
matthijseikelenboom commented on issue #10454:
URL: https://github.com/apache/iceberg/issues/10454#issuecomment-2155058569
@szehon-ho I saw that I forgot to copy over the retry mechanism that we
build. It has been included in the latest commit. Another interesting thing, is
that when you se
RussellSpitzer commented on issue #10454:
URL: https://github.com/apache/iceberg/issues/10454#issuecomment-2154964023
In between flights I found another suspect thing which was when a row was
deleted the transaction log still attempts to find it rather than check for its
absence. Gonna slee
szehon-ho commented on issue #10454:
URL: https://github.com/apache/iceberg/issues/10454#issuecomment-2154449447
Yea , I think @RussellSpitzer has a good point.
I think this code
https://github.com/matthijseikelenboom/iceberg-acid-verification/blob/master/src/main/java/org/example/wri
RussellSpitzer commented on issue #10454:
URL: https://github.com/apache/iceberg/issues/10454#issuecomment-2154176716
Looking briefly at the code it looks like the error may be in the retry
logic for the transaction statements as written. From what I can tell the code
does not handle Iceber
matthijseikelenboom commented on issue #10454:
URL: https://github.com/apache/iceberg/issues/10454#issuecomment-2153255225
SparkSessionProvider.java - line 68:
`.config("spark.sql.catalog.iceberghive.cache-enabled", "false")`
If this is the property that you mean, then yes
--
This
RussellSpitzer commented on issue #10454:
URL: https://github.com/apache/iceberg/issues/10454#issuecomment-2153056909
Is the Catalog Cache in use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
matthijseikelenboom commented on issue #10454:
URL: https://github.com/apache/iceberg/issues/10454#issuecomment-2152766019
@nastra The README of the repo describes in detail what the test does. But
in short: The test fails because what it expects to be present on disc, isn't
there. On the t
nastra commented on issue #10454:
URL: https://github.com/apache/iceberg/issues/10454#issuecomment-2152494225
@matthijseikelenboom can you please share details of what exactly is failing
in which scenario for the people that aren't running the test? This makes it
easier to reason about what
15 matches
Mail list logo
