Re: [I] Adjust the "table_exists" behavior in the REST Catalog [iceberg-python]

2024-11-12 Thread via GitHub
djouallah commented on issue #1018: URL: https://github.com/apache/iceberg-python/issues/1018#issuecomment-2471827257 catalog.url(Endpoints.load_table, prefixed=True, **catalog._split_identifier_for_path(identifier_tuple)) https://x-polaris.snowflakecomputing.com/polaris/api/cat

Re: [I] Adjust the "table_exists" behavior in the REST Catalog [iceberg-python]

2024-11-12 Thread via GitHub
kevinjqliu commented on issue #1018: URL: https://github.com/apache/iceberg-python/issues/1018#issuecomment-2470984189 404 would make `table_exists` return `False` https://github.com/apache/iceberg-python/blob/b7942a85dfb74ce3736c5088995e7bd0b996d56b/pyiceberg/catalog/rest.py#L889-L890

Re: [I] Adjust the "table_exists" behavior in the REST Catalog [iceberg-python]

2024-11-11 Thread via GitHub
djouallah commented on issue #1018: URL: https://github.com/apache/iceberg-python/issues/1018#issuecomment-2469713958 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [I] Adjust the "table_exists" behavior in the REST Catalog [iceberg-python]

2024-11-11 Thread via GitHub
kevinjqliu commented on issue #1018: URL: https://github.com/apache/iceberg-python/issues/1018#issuecomment-2469629719 something like this, following the `table_exists` implementation https://github.com/apache/iceberg-python/blob/b7942a85dfb74ce3736c5088995e7bd0b996d56b/pyiceberg/catalog

Re: [I] Adjust the "table_exists" behavior in the REST Catalog [iceberg-python]

2024-11-11 Thread via GitHub
djouallah commented on issue #1018: URL: https://github.com/apache/iceberg-python/issues/1018#issuecomment-2469375855 Sorry, how to do that ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Adjust the "table_exists" behavior in the REST Catalog [iceberg-python]

2024-11-11 Thread via GitHub
kevinjqliu commented on issue #1018: URL: https://github.com/apache/iceberg-python/issues/1018#issuecomment-2468721923 I think the issue here is that `catalog.table_exists(tbl)` returns `False` when the table already exists. @djouallah can you check what the the response/status code

Re: [I] Adjust the "table_exists" behavior in the REST Catalog [iceberg-python]

2024-11-10 Thread via GitHub
djouallah commented on issue #1018: URL: https://github.com/apache/iceberg-python/issues/1018#issuecomment-2467190119 still getting errors with with pyiceberg 0.8 rc1 ``` HTTPError Traceback (most recent call last) [/usr/local/lib/python3.10/dist

Re: [I] Adjust the "table_exists" behavior in the REST Catalog [iceberg-python]

2024-09-02 Thread via GitHub
ndrluis closed issue #1018: Adjust the "table_exists" behavior in the REST Catalog URL: https://github.com/apache/iceberg-python/issues/1018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [I] Adjust the "table_exists" behavior in the REST Catalog [iceberg-python]

2024-09-01 Thread via GitHub
kevinjqliu commented on issue #1018: URL: https://github.com/apache/iceberg-python/issues/1018#issuecomment-2323378037 @ndrluis can this be closed now that #1096 is merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] Adjust the "table_exists" behavior in the REST Catalog [iceberg-python]

2024-08-23 Thread via GitHub
Fokko commented on issue #1018: URL: https://github.com/apache/iceberg-python/issues/1018#issuecomment-2307288863 I checked the Java side, and I could not find the HEAD request. For raising visibility, I created an issue there: https://github.com/apache/iceberg/issues/10993 -- This is a

Re: [I] Adjust the "table_exists" behavior in the REST Catalog [iceberg-python]

2024-08-23 Thread via GitHub
Fokko commented on issue #1018: URL: https://github.com/apache/iceberg-python/issues/1018#issuecomment-2307278079 Thanks everyone for bringing this up. Long term, I think we should leverage the endpoint discovery to see if the server provides the capability of table-exists: https://

Re: [I] Adjust the "table_exists" behavior in the REST Catalog [iceberg-python]

2024-08-23 Thread via GitHub
sungwy commented on issue #1018: URL: https://github.com/apache/iceberg-python/issues/1018#issuecomment-2307215308 Hi @TiansuYu and @ndrluis - thank you for bringing up this point, and sorry for not getting around to looking at this earlier. Similar to what @TiansuYu suggested, I'm o

Re: [I] Adjust the "table_exists" behavior in the REST Catalog [iceberg-python]

2024-08-23 Thread via GitHub
sungwy commented on issue #1018: URL: https://github.com/apache/iceberg-python/issues/1018#issuecomment-2307216929 > @ndrluis @kevinjqliu I can contribute to this. Would you say the intended behavior should be: > > * 204 return True > * 404 NoSuchTableException > * others: rais

Re: [I] Adjust the "table_exists" behavior in the REST Catalog [iceberg-python]

2024-08-23 Thread via GitHub

Re: [I] Adjust the "table_exists" behavior in the REST Catalog [iceberg-python]

2024-08-23 Thread via GitHub
TiansuYu commented on issue #1018: URL: https://github.com/apache/iceberg-python/issues/1018#issuecomment-2306469445 I can contribute to this. Would you say the intended behavior should be: - 204 return True - 404 TableNotExistsException - others: raise a corresponding response e

Re: [I] Adjust the "table_exists" behavior in the REST Catalog [iceberg-python]

2024-08-07 Thread via GitHub
kevinjqliu commented on issue #1018: URL: https://github.com/apache/iceberg-python/issues/1018#issuecomment-2273855146 Thanks for looking into this. The behavior you described above seems like the correct one to me. > I believe that this behavior is suppressing errors and looks like