Re: [PR] typealias for table version [iceberg-python]

2024-04-03 Thread via GitHub
MehulBatra commented on PR #566: URL: https://github.com/apache/iceberg-python/pull/566#issuecomment-2034449315 > Thanks for working on this @MehulBatra 🙌 Always great to work on Iceberg and learn from you and the team! -- This is an automated message from the Apache Git Service. To

Re: [PR] typealias for table version [iceberg-python]

2024-04-03 Thread via GitHub
Fokko merged PR #566: URL: https://github.com/apache/iceberg-python/pull/566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] typealias for table version [iceberg-python]

2024-03-31 Thread via GitHub
MehulBatra commented on code in PR #566: URL: https://github.com/apache/iceberg-python/pull/566#discussion_r1546000951 ## pyiceberg/typedef.py: ## @@ -199,3 +200,6 @@ def __repr__(self) -> str: def record_fields(self) -> List[str]: """Return values of all the field

Re: [PR] typealias for table version [iceberg-python]

2024-03-31 Thread via GitHub
Fokko commented on code in PR #566: URL: https://github.com/apache/iceberg-python/pull/566#discussion_r1545787435 ## pyiceberg/typedef.py: ## @@ -199,3 +200,6 @@ def __repr__(self) -> str: def record_fields(self) -> List[str]: """Return values of all the fields of

[PR] typealias for table version [iceberg-python]

2024-03-31 Thread via GitHub
MehulBatra opened a new pull request, #566: URL: https://github.com/apache/iceberg-python/pull/566 Create TypeAlias for the version method return, to ensure the type safety, readability & maintainability. -- This is an automated message from the Apache Git Service. To respond to the mess