Re: [PR] support all_entries in pyiceberg [iceberg-python]

2025-02-17 Thread via GitHub
amitgilad3 commented on code in PR #1608: URL: https://github.com/apache/iceberg-python/pull/1608#discussion_r1958750651 ## pyiceberg/table/inspect.py: ## @@ -157,74 +158,96 @@ def _readable_metrics_struct(bound_type: PrimitiveType) -> pa.StructType: pa.field("

Re: [PR] support all_entries in pyiceberg [iceberg-python]

2025-02-16 Thread via GitHub
kevinjqliu commented on code in PR #1608: URL: https://github.com/apache/iceberg-python/pull/1608#discussion_r1957418226 ## pyiceberg/table/inspect.py: ## @@ -157,74 +158,96 @@ def _readable_metrics_struct(bound_type: PrimitiveType) -> pa.StructType: pa.field("

Re: [PR] support all_entries in pyiceberg [iceberg-python]

2025-02-10 Thread via GitHub
amitgilad3 commented on PR #1608: URL: https://github.com/apache/iceberg-python/pull/1608#issuecomment-2648831468 Ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] support all_entries in pyiceberg [iceberg-python]

2025-02-08 Thread via GitHub
kevinjqliu commented on code in PR #1608: URL: https://github.com/apache/iceberg-python/pull/1608#discussion_r1947916711 ## tests/integration/test_inspect_table.py: ## @@ -938,3 +938,111 @@ def test_inspect_all_manifests(spark: SparkSession, session_catalog: Catalog, fo lh

Re: [PR] support all_entries in pyiceberg [iceberg-python]

2025-02-05 Thread via GitHub
amitgilad3 commented on PR #1608: URL: https://github.com/apache/iceberg-python/pull/1608#issuecomment-2638045119 Ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] support all_entries in pyiceberg [iceberg-python]

2025-02-04 Thread via GitHub
amitgilad3 commented on PR #1608: URL: https://github.com/apache/iceberg-python/pull/1608#issuecomment-2634621892 will try -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] support all_entries in pyiceberg [iceberg-python]

2025-02-04 Thread via GitHub
kevinjqliu commented on PR #1608: URL: https://github.com/apache/iceberg-python/pull/1608#issuecomment-2634618707 > the number of entries returned by spark is less then what pyiceberg returns and i'm not sure why looks like there are a lot of dups in pyiceberg. if you do set and sort

[PR] support all_entries in pyiceberg [iceberg-python]

2025-02-04 Thread via GitHub
amitgilad3 opened a new pull request, #1608: URL: https://github.com/apache/iceberg-python/pull/1608 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc