Re: [PR] spec: Remove `source-ids` for `V{1,2}` tables [iceberg]

Fokko merged PR #12161: URL: https://github.com/apache/iceberg/pull/12161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] spec: Remove `source-ids` for `V{1,2}` tables [iceberg]

szehon-ho commented on PR #12161: URL: https://github.com/apache/iceberg/pull/12161#issuecomment-2641373672 Thanks @Fokko initially was hoping that we could support it for v1/v2 tables but understand the issues you are pointing out. I guess we can patiently wait v3 tables then! -- This

Re: [PR] spec: Remove `source-ids` for `V{1,2}` tables [iceberg]

Fokko commented on PR #12161: URL: https://github.com/apache/iceberg/pull/12161#issuecomment-2636599919 @advancedxy Thanks for jumping in here. Yes, I hope to complete the V3 spec soon. By simplifying the impl as suggested in this spec, it will also be easier to implement in PyIceberg. Feel

Re: [PR] spec: Remove `source-ids` for `V{1,2}` tables [iceberg]

advancedxy commented on PR #12161: URL: https://github.com/apache/iceberg/pull/12161#issuecomment-2635591315 @Fokko Thanks for bring this up. I'm supporting this to only allow multi-arg transforms for V3 onwards. When multi-arg transform was first added to the spec, V3 was far from completi

Re: [PR] spec: Remove `source-ids` for `V{1,2}` tables [iceberg]

RussellSpitzer commented on code in PR #12161: URL: https://github.com/apache/iceberg/pull/12161#discussion_r1939350765 ## format/spec.md: ## @@ -1379,7 +1379,7 @@ Each partition field in `fields` is stored as a JSON object with the following p | V1 | V2 | V3

Re: [PR] spec: Remove `source-ids` for `V{1,2}` tables [iceberg]

Fokko commented on code in PR #12161: URL: https://github.com/apache/iceberg/pull/12161#discussion_r1938946299 ## format/spec.md: ## @@ -1400,7 +1400,7 @@ In some cases partition specs are stored using only the field list instead of th The `field-id` property was added for e

Re: [PR] spec: Remove `source-ids` for `V{1,2}` tables [iceberg]

Fokko commented on PR #12161: URL: https://github.com/apache/iceberg/pull/12161#issuecomment-2630237189 > By the way I gonna start impl side of the thing :) SGTM, if you do the Java side, I'm happy to take care of PyIceberg 👍 -- This is an automated message from the Apache Git

Re: [PR] spec: Remove `source-ids` for `V{1,2}` tables [iceberg]

jbonofre commented on PR #12161: URL: https://github.com/apache/iceberg/pull/12161#issuecomment-2630172217 By the way I gonna start impl side of the thing :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] spec: Remove `source-ids` for `V{1,2}` tables [iceberg]

jbonofre commented on code in PR #12161: URL: https://github.com/apache/iceberg/pull/12161#discussion_r1938866471 ## format/spec.md: ## @@ -1400,7 +1400,7 @@ In some cases partition specs are stored using only the field list instead of th The `field-id` property was added fo

Re: [PR] spec: Remove `source-ids` for `V{1,2}` tables [iceberg]

jbonofre commented on PR #12161: URL: https://github.com/apache/iceberg/pull/12161#issuecomment-2630102760 @Fokko Thanks ! As discussed together, I was about to propose this, so totally agree ! -- This is an automated message from the Apache Git Service. To respond to the message, please

[PR] spec: Remove `source-ids` for `V{1,2}` tables [iceberg]

Fokko opened a new pull request, #12161: URL: https://github.com/apache/iceberg/pull/12161 I was looking at adding support for `source-ids` in PyIceberg, but noticed that it was also still lacking for Java. I've noticed that `source-ids` are also backported to V1 and V2 tables, which