Re: [PR] scan: fix error when reading an empty table [iceberg-rust]

2024-09-23 Thread via GitHub
Xuanwo commented on PR #608: URL: https://github.com/apache/iceberg-rust/pull/608#issuecomment-2368247337 > We've been very selective when it comes to adding new values to `ErrorKind`. I'd personally go for `Unexpected` here - but maybe @liurenjie1024 or @Xuanwo can confirm what would be be

Re: [PR] scan: fix error when reading an empty table [iceberg-rust]

2024-09-11 Thread via GitHub
sdd commented on PR #608: URL: https://github.com/apache/iceberg-rust/pull/608#issuecomment-2344385358 We've been very selective when it comes to adding new values to `ErrorKind`. I'd personally go for `Unexpected` here - but maybe @liurenjie1024 or @Xuanwo can confirm what would be best.

Re: [PR] scan: fix error when reading an empty table [iceberg-rust]

2024-09-09 Thread via GitHub
sdd commented on PR #608: URL: https://github.com/apache/iceberg-rust/pull/608#issuecomment-2338064061 Just to clarify, not having any snapshots is not necessarily the same as not having any data. If there is no current snapshot then there can't be any data, but someone could delete all dat