zeroshade merged PR #252:
URL: https://github.com/apache/iceberg-go/pull/252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
zeroshade commented on code in PR #252:
URL: https://github.com/apache/iceberg-go/pull/252#discussion_r1913882185
##
table/scanner.go:
##
@@ -259,129 +286,119 @@ func matchDeletesToData(entry iceberg.ManifestEntry,
positionalDeletes []iceberg
return out, nil
}
-func
zeroshade commented on code in PR #252:
URL: https://github.com/apache/iceberg-go/pull/252#discussion_r1913854651
##
table/scanner.go:
##
@@ -259,129 +286,119 @@ func matchDeletesToData(entry iceberg.ManifestEntry,
positionalDeletes []iceberg
return out, nil
}
-func
iskakaushik commented on code in PR #252:
URL: https://github.com/apache/iceberg-go/pull/252#discussion_r1913861589
##
table/scanner.go:
##
@@ -259,129 +286,119 @@ func matchDeletesToData(entry iceberg.ManifestEntry,
positionalDeletes []iceberg
return out, nil
}
-fun
iskakaushik opened a new pull request, #252:
URL: https://github.com/apache/iceberg-go/pull/252
This refactor breaks down the manifest scanning logic into more focused
components in preparation for adding incremental scanners to allow reading
changelog and diffs between two snapshots.
